Skip to content

[Xamarin.Android.Build.Tasks] remove HasClassFiles checks #9293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2024
Merged

[Xamarin.Android.Build.Tasks] remove HasClassFiles checks #9293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/Xamarin.Android.Build.Tasks/Tasks/DetermineJavaLibrariesToCompile.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
using Microsoft.Build.Framework;
using System.Linq;
using System.IO;
using Xamarin.Android.Tools;
using Microsoft.Android.Build.Tasks;

namespace Xamarin.Android.Tasks
Expand Down Expand Up @@ -58,8 +57,6 @@ public override bool RunTask ()
referenceJavaLibraries.AddRange (ExternalJavaLibraries);

foreach (var item in distinct) {
if (!HasClassFiles (item.ItemSpec))
continue;
if (IsExcluded (item.ItemSpec)) {
referenceJavaLibraries.Add (item);
} else {
Expand All @@ -75,11 +72,6 @@ public override bool RunTask ()
return true;
}

bool HasClassFiles (string jar)
{
return Files.ZipAny (jar, entry => entry.FullName.EndsWith (".class", StringComparison.OrdinalIgnoreCase));
}

bool IsExcluded (string jar)
{
if (DoNotPackageJavaLibraries == null)
Expand Down
Loading