[Xamarin.Android.Build.Tasks] remove HasClassFiles checks
#9293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet#2882 During an incremental build + deploy of a `dotnet new maui` project, I noticed time spent in: 62.52ms (1.8%) xamarin.android.build.tasks!Xamarin.Android.Tasks.DetermineJavaLibrariesToCompile.HasClassFiles(class System.String) What's worse, is this happens once for build and again for deploy. Because there are 100+ `.jar` files, we are actively opening each one with libZipSharp to determine if there are any `.class` files. In e6326dc, we added the `HasClassFiles()` call to fix a problem with "Enhanced Fast Deployment". However, we have since completely removed this feature in: * xamarin/monodroid@93ab95e * xamarin/monodroid@2c64cd5 Removing the `HasClassFiles()` method completely, should improve the inner loop by around 120ms for `dotnet new maui` projects.
dellis1972
approved these changes
Sep 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #2882
During an incremental build + deploy of a
dotnet new mauiproject, I noticed time spent in:What's worse, is this happens once for build and again for deploy. Because there are 100+
.jarfiles, we are actively opening each one with libZipSharp to determine if there are any.classfiles.In e6326dc, we added the
HasClassFiles()call to fix a problem with "Enhanced Fast Deployment". However, we have since completely removed this feature in:Removing the
HasClassFiles()method completely, should improve the inner loop by around 120ms fordotnet new mauiprojects.