Skip to content
This repository was archived by the owner on Jan 15, 2024. It is now read-only.

Conversation

leezu
Copy link
Contributor

@leezu leezu commented Jun 11, 2019

Description

This adds tests to prevent #753 from happening again.
While the two models are currently deprecated, they need nevertheless to be tested until support is completely dropped.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Comments

Fixes #753

@leezu leezu requested a review from szha as a code owner June 11, 2019 12:49
@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #764 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #764      +/-   ##
=========================================
+ Coverage   90.69%   90.7%   +0.01%     
=========================================
  Files          64      64              
  Lines        6113    6110       -3     
=========================================
- Hits         5544    5542       -2     
+ Misses        569     568       -1
Impacted Files Coverage Δ
src/gluonnlp/model/bert.py 100% <ø> (+0.72%) ⬆️
src/gluonnlp/data/utils.py 74.14% <ø> (ø) ⬆️

@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

❗ No coverage uploaded for pull request head (addbertmodeltests@9d5068e). Click here to learn what that means.
The diff coverage is n/a.

@leezu leezu requested a review from eric-haibin-lin June 11, 2019 12:56
@leezu leezu force-pushed the addbertmodeltests branch from 9d5068e to bf22ab7 Compare June 11, 2019 14:51
@mli
Copy link
Member

mli commented Jun 11, 2019

Job PR-764/2 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-764/2/index.html

@szha szha changed the title [TESTS] Add wiki_multilingual and wiki_cn to test_models.py Dropping support for wiki_multilingual and wiki_cn Jun 11, 2019
@szha szha changed the title Dropping support for wiki_multilingual and wiki_cn [API] Dropping support for wiki_multilingual and wiki_cn Jun 11, 2019
fix lint
@mli
Copy link
Member

mli commented Jun 11, 2019

Job PR-764/4 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-764/4/index.html

@mli
Copy link
Member

mli commented Jun 11, 2019

Job PR-764/5 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-764/5/index.html

@eric-haibin-lin eric-haibin-lin merged commit a0dbf06 into dmlc:master Jun 11, 2019
@leezu leezu deleted the addbertmodeltests branch June 12, 2019 00:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing wiki_cn Bert vocab artifacts on S3
4 participants