Skip to content
This repository was archived by the owner on Jan 15, 2024. It is now read-only.

Commit a0dbf06

Browse files
leezueric-haibin-lin
authored andcommitted
[API] Dropping support for wiki_multilingual and wiki_cn (#764)
* Add wiki_multilingual and wiki_cn to test_models.py * Drop deprecated wiki_cn wiki_multilingual bert model names * Update bert.py fix lint * Update hybrid_bert.py fix lint
1 parent 3385c72 commit a0dbf06

File tree

4 files changed

+1
-13
lines changed

4 files changed

+1
-13
lines changed

scripts/bert/export/hybrid_bert.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525

2626
import os
2727
import math
28-
import warnings
2928

3029
import mxnet as mx
3130
from mxnet.gluon import Block, HybridBlock
@@ -766,9 +765,6 @@ def get_hybrid_bert_model(model_name=None, dataset_name=None, vocab=None,
766765
use_residual=predefined_args['use_residual'],
767766
input_size=input_size,
768767
seq_length=seq_length)
769-
if dataset_name in ['wiki_cn', 'wiki_multilingual']:
770-
warnings.warn('wiki_cn/wiki_multilingual will be deprecated.'
771-
' Please use wiki_cn_cased/wiki_multilingual_uncased instead.')
772768
bert_vocab = _load_vocab(dataset_name, vocab, root, cls=BERTVocab)
773769
# BERT
774770
net = HybridBERTModel(encoder, len(bert_vocab),

src/gluonnlp/data/utils.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -225,9 +225,7 @@ def _slice_pad_length(num_items, length, overlap=0):
225225
'book_corpus_wiki_en_uncased': 'a66073971aa0b1a262453fe51342e57166a8abcf',
226226
'wiki_multilingual_cased': '0247cb442074237c38c62021f36b7a4dbd2e55f7',
227227
'wiki_cn_cased': 'ddebd8f3867bca5a61023f73326fb125cf12b4f5',
228-
'wiki_cn': 'ddebd8f3867bca5a61023f73326fb125cf12b4f5',
229228
'wiki_multilingual_uncased': '2b2514cc539047b9179e9d98a4e68c36db05c97a',
230-
'wiki_multilingual': '2b2514cc539047b9179e9d98a4e68c36db05c97a',
231229
'scibert_scivocab_uncased': '2d2566bfc416790ab2646ab0ada36ba628628d60',
232230
'scibert_scivocab_cased': '2c714475b521ab8542cb65e46259f6bfeed8041b',
233231
'scibert_basevocab_uncased': '80ef760a6bdafec68c99b691c94ebbb918c90d02',

src/gluonnlp/model/bert.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
'ernie_12_768_12']
2424

2525
import os
26-
import warnings
2726
from mxnet.gluon import Block
2827
from mxnet.gluon import nn
2928
from mxnet.gluon.model_zoo import model_store
@@ -501,10 +500,8 @@ def _decode(self, sequence, masked_positions):
501500
{name: checksum for checksum, name in [
502501
('5656dac6965b5054147b0375337d5a6a7a2ff832', 'bert_12_768_12_book_corpus_wiki_en_cased'),
503502
('75cc780f085e8007b3bf6769c6348bb1ff9a3074', 'bert_12_768_12_book_corpus_wiki_en_uncased'),
504-
('237f39851b24f0b56d70aa20efd50095e3926e26', 'bert_12_768_12_wiki_multilingual'),
505503
('237f39851b24f0b56d70aa20efd50095e3926e26', 'bert_12_768_12_wiki_multilingual_uncased'),
506504
('b0f57a207f85a7d361bb79de80756a8c9a4276f7', 'bert_12_768_12_wiki_multilingual_cased'),
507-
('885ebb9adc249a170c5576e90e88cfd1bbd98da6', 'bert_12_768_12_wiki_cn'),
508505
('885ebb9adc249a170c5576e90e88cfd1bbd98da6', 'bert_12_768_12_wiki_cn_cased'),
509506
('4e685a966f8bf07d533bd6b0e06c04136f23f620', 'bert_24_1024_16_book_corpus_wiki_en_cased'),
510507
('24551e1446180e045019a87fc4ffbf714d99c0b5', 'bert_24_1024_16_book_corpus_wiki_en_uncased'),
@@ -843,9 +840,6 @@ def get_bert_model(model_name=None, dataset_name=None, vocab=None, pretrained=Tr
843840
layer_norm_eps=predefined_args.get('layer_norm_eps', None))
844841
# bert_vocab
845842
from ..vocab import BERTVocab
846-
if dataset_name in ['wiki_cn', 'wiki_multilingual']:
847-
warnings.warn('wiki_cn/wiki_multilingual will be deprecated. '
848-
'Please use wiki_cn_cased/wiki_multilingual_uncased instead.')
849843
bert_vocab = _load_vocab(dataset_name, vocab, root, cls=BERTVocab)
850844
# BERT
851845
net = BERTModel(encoder, len(bert_vocab),

tests/unittest/test_models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ def test_pretrained_bert_models(disable_missing_parameters):
107107
'wiki_multilingual_cased', 'wiki_cn_cased', 'scibert_scivocab_uncased',
108108
'scibert_scivocab_cased', 'scibert_basevocab_uncased', 'scibert_basevocab_cased',
109109
'biobert_v1.0_pmc_cased', 'biobert_v1.0_pubmed_cased', 'biobert_v1.0_pubmed_pmc_cased',
110-
'biobert_v1.1_pubmed_cased', 'clinicalbert_uncased'
110+
'biobert_v1.1_pubmed_cased', 'clinicalbert_uncased',
111111
],
112112
'bert_24_1024_16': ['book_corpus_wiki_en_uncased', 'book_corpus_wiki_en_cased']
113113
}

0 commit comments

Comments
 (0)