Skip to content

Various spelling, proofreading, wording fixes. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Oct 5, 2024

Conversation

nissa-seru
Copy link
Contributor

@nissa-seru nissa-seru commented Jul 25, 2024

Thanks for translating this mod to EN! I've made some spelling/proofreading/wording changes to improve readability during my playthroughs - submitting as a PR in case helpful to continued progress in EN localization of the mod.

Also updated the game version in a12dd51 to prevent the mod from being auto-disabled due to specifying 0.96a as a dependency.

@nissa-seru
Copy link
Contributor Author

Fixed some more issues that I came across during playtesting.

@nissa-seru
Copy link
Contributor Author

Added support for Version Checker in 59b8d66 - the only maintenance required should be to increment the patch version in XXVIIBattleGroup.version whenever it is incremented in mod_info.json.

Copy link
Owner

@dilinganye dilinganye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fixes, great thanks to nissa-seru

@nissa-seru
Copy link
Contributor Author

Hi @dilinganye, just sharing as a quick note; I'm unable to merge this PR into the base branch (even after your approval.) Given the permission setup of the repo, I think you may need to merge the PR yourself to apply the updates.

@dilinganye dilinganye merged commit aff672f into dilinganye:main Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants