Skip to content

fix(ext/node): support JS underlying stream in TLS #30465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 28, 2025
Merged

fix(ext/node): support JS underlying stream in TLS #30465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9404dcc
charlie xcx
littledivy Aug 20, 2025
7486f51
fuck
littledivy Aug 20, 2025
0ece008
cleanup
littledivy Aug 20, 2025
180148e
keep it on
littledivy Aug 20, 2025
760ed9c
stuff
littledivy Aug 20, 2025
b0ebfa6
Add test
littledivy Aug 20, 2025
e4eb9f8
lint
littledivy Aug 20, 2025
0203df5
rm old test
littledivy Aug 20, 2025
f40ca72
x
littledivy Aug 20, 2025
ce4ffd4
REview
littledivy Aug 28, 2025
321a52f
Fix rebase
littledivy Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions ext/node/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ deno_package_json.workspace = true
deno_path_util.workspace = true
deno_permissions.workspace = true
deno_process.workspace = true
deno_tls.workspace = true
deno_whoami.workspace = true
der = { workspace = true, features = ["derive"] }
digest = { workspace = true, features = ["core-api", "std"] }
Expand Down Expand Up @@ -78,6 +79,7 @@ rand.workspace = true
ripemd = { workspace = true, features = ["oid"] }
rsa.workspace = true
rusqlite.workspace = true
rustls-tokio-stream.workspace = true
scrypt.workspace = true
sec1.workspace = true
serde.workspace = true
Expand Down
3 changes: 0 additions & 3 deletions ext/node/clippy.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,3 @@ disallowed-methods = [
{ path = "std::fs::symlink_metadata", reason = "File system operations should be done using FileSystem trait" },
{ path = "std::fs::write", reason = "File system operations should be done using FileSystem trait" },
]
disallowed-types = [
{ path = "std::sync::Arc", reason = "use deno_fs::sync::MaybeArc instead" },
]
Comment on lines -31 to -33
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this on purpose?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the lint rule doesn't help with anything. https://deno-company.slack.com/archives/C03P8NFAJTY/p1755693378481979

2 changes: 2 additions & 0 deletions ext/node/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,6 +460,8 @@ deno_core::extension!(deno_node,
ops::tls::op_get_root_certificates,
ops::tls::op_tls_peer_certificate,
ops::tls::op_tls_canonicalize_ipv4_address,
ops::tls::op_node_tls_start,
ops::tls::op_node_tls_handshake,
ops::inspector::op_inspector_open<P>,
ops::inspector::op_inspector_close,
ops::inspector::op_inspector_url,
Expand Down
Loading
Loading