fix(ext/node): support JS underlying stream in TLS #30465

littledivy · 2025-08-20T13:12:19Z

Fixes #20594

This implements JSStreamSocket which drives the TLS underlying stream in rustls_tokio_stream using 2 sets of channels. One for piping the encrypted protocol transport and the other for plaintext application data.

This fixes connecting to npm:mssql:

import sql from "npm:mssql";

const sqlConfig = {
  server: "localhost",
  user: "divy",
  password: "123",
  database: "master",
  options: {
    trustServerCertificate: true,
  },
};

const pool = await sql.connect(sqlConfig);
const result = await pool.request().query(`SELECT * FROM sys.databases`);

bartlomieju · 2025-08-27T11:24:25Z

ext/node/clippy.toml

-disallowed-types = [
-  { path = "std::sync::Arc", reason = "use deno_fs::sync::MaybeArc instead" },
-]


Is this on purpose?

Yes, the lint rule doesn't help with anything. https://deno-company.slack.com/archives/C03P8NFAJTY/p1755693378481979

ext/node/ops/tls.rs

bartlomieju · 2025-08-27T11:30:48Z

ext/node/ops/tls.rs

+  let (network_to_tls_tx, network_to_tls_rx) =
+    tokio::sync::mpsc::channel::<Bytes>(10);
+  let (tls_to_network_tx, tls_to_network_rx) =
+    tokio::sync::mpsc::channel::<Bytes>(10);


Are these totally random buffer sizes?

Yeah, it would never have more than 1 message in queue though.

bartlomieju · 2025-08-27T11:31:04Z

ext/node/ops/tls.rs

+  let tls_stream = TlsStream::new_client_side(
+    js_stream,
+    ClientConnection::new(tls_config, hostname_dns)?,
+    NonZeroUsize::new(65536),


Same here, where does this come from?

It comes from here:

deno/ext/net/ops_tls.rs

Lines 63 to 64 in c217928

pub(crate) const TLS_BUFFER_SIZE: Option<NonZeroUsize> =

NonZeroUsize::new(65536);

bartlomieju · 2025-08-27T11:31:41Z

ext/node/polyfills/net.ts

 Socket.prototype._unrefTimer = function () {
  // deno-lint-ignore no-this-alias
-  for (let s = this; s !== null; s = s._parent) {
+  for (let s = this; s != null; s = s._parent) {


Are these unrelated changes?

Yes, _parent can be undefined (not just null) when s is JSStreamSocket

tests/unit_node/tls_test.ts

bartlomieju · 2025-08-27T11:32:09Z

tests/unit_node/tls_test.ts

Great, are there any other node compat tests we could enable?

No new tests pass immediately with this PR

sant123 · 2025-08-28T15:32:27Z

Thanks, thanks a lot for this 🙏🏼

This was referenced Aug 20, 2025

fix(ext/node): reimplement TLSSocket and TLSWrap #30394

Closed

fix(ext/node): support Duplex stream for TLS termination #30202

Closed

littledivy requested a review from bartlomieju August 22, 2025 17:43

bartlomieju reviewed Aug 27, 2025

View reviewed changes

bartlomieju approved these changes Aug 28, 2025

View reviewed changes

littledivy added 11 commits August 28, 2025 17:15

charlie xcx

9404dcc

fuck

7486f51

cleanup

0ece008

keep it on

180148e

stuff

760ed9c

Add test

b0ebfa6

lint

e4eb9f8

rm old test

0203df5

x

f40ca72

REview

ce4ffd4

Fix rebase

321a52f

littledivy force-pushed the jsstreamsocket_fr_pmo branch from 5fdaca8 to 321a52f Compare August 28, 2025 11:48

littledivy merged commit 36e9eb2 into denoland:main Aug 28, 2025
19 checks passed

sant123 mentioned this pull request Aug 28, 2025

mssql close() is not working #30556

Open

	pub(crate) const TLS_BUFFER_SIZE: Option<NonZeroUsize> =
	NonZeroUsize::new(65536);

fix(ext/node): support JS underlying stream in TLS #30465

fix(ext/node): support JS underlying stream in TLS #30465

Uh oh!

Conversation

littledivy commented Aug 20, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

littledivy Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sant123 commented Aug 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

littledivy Aug 28, 2025 •

edited

Loading