Skip to content

perf(ext/http): Reduce size of ResponseBytesInner #24840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2024
Merged

perf(ext/http): Reduce size of ResponseBytesInner #24840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions ext/http/response_body.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,9 @@ pub enum ResponseBytesInner {
/// An uncompressed stream.
UncompressedStream(ResponseStream),
/// A GZip stream.
GZipStream(GZipResponseStream),
GZipStream(Box<GZipResponseStream>),
/// A Brotli stream.
BrotliStream(BrotliResponseStream),
BrotliStream(Box<BrotliResponseStream>),
}

impl std::fmt::Debug for ResponseBytesInner {
Expand Down Expand Up @@ -133,9 +133,11 @@ impl ResponseBytesInner {

fn from_stream(compression: Compression, stream: ResponseStream) -> Self {
match compression {
Compression::GZip => Self::GZipStream(GZipResponseStream::new(stream)),
Compression::GZip => {
Self::GZipStream(Box::new(GZipResponseStream::new(stream)))
}
Compression::Brotli => {
Self::BrotliStream(BrotliResponseStream::new(stream))
Self::BrotliStream(Box::new(BrotliResponseStream::new(stream)))
}
_ => Self::UncompressedStream(stream),
}
Expand Down
4 changes: 2 additions & 2 deletions ext/http/service.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,10 +545,10 @@ impl Body for HttpRecordResponse {
ready!(Pin::new(stm).poll_frame(cx))
}
ResponseBytesInner::GZipStream(stm) => {
ready!(Pin::new(stm).poll_frame(cx))
ready!(Pin::new(stm.as_mut()).poll_frame(cx))
}
ResponseBytesInner::BrotliStream(stm) => {
ready!(Pin::new(stm).poll_frame(cx))
ready!(Pin::new(stm.as_mut()).poll_frame(cx))
}
};
// This is where we retry the NoData response
Expand Down