perf(ext/http): Reduce size of ResponseBytesInner
#24840
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed
set_response_body
was unexpectedly hot in profiles, with most of the time being spent inmemmove
.It turns out that
ResponseBytesInner
was massive (5624 bytes), so every time we moved aResponseBytesInner
(for instance inset_response_body
) we were doing a >5kb memmove, which adds up pretty quickly.This PR boxes the two larger variants (the compression streams), shrinking
ResponseBytesInner
to a reasonable 48 bytes.Benchmarked with a simple hello world server:
Main:
This PR:
So a nice ~15% bump. (With response body compression, the gain is ~10% for gzip and neutral for brotli)