-
Notifications
You must be signed in to change notification settings - Fork 5.8k
feat(cli/test): add DENO_JOBS env variable for test subcommand
#14929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dsherret
merged 6 commits into
denoland:main
from
mrkldshv:feature/cli-test-jobs-env-variable
Jul 15, 2022
Merged
feat(cli/test): add DENO_JOBS env variable for test subcommand
#14929
dsherret
merged 6 commits into
denoland:main
from
mrkldshv:feature/cli-test-jobs-env-variable
Jul 15, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrkldshv
commented
Jun 21, 2022
dsherret
reviewed
Jun 22, 2022
c84e5a5 to
b543343
Compare
fb370e2 to
03f29cc
Compare
dsherret
requested changes
Jun 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks good to me, but just a couple small changes.
dsherret
reviewed
Jun 30, 2022
e2ff725 to
113c80f
Compare
113c80f to
05c885b
Compare
dsherret
approved these changes
Jul 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @mrkldshv!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All changes in this MR concern
testsubcommand. The implemented behaviour for running tests is:Deprecate usage ofEdit: See feat(cli/test): add--jobsflag with numeric values (e.g.--jobs=2)DENO_JOBSenv variable fortestsubcommand #14929 (comment)DENO_JOBSenv variable that is used with--jobsflag (usage:DENO_JOBS=2 deno test --jobs)--jobsflag is provided without value and there is noDENO_JOBSenv variable setAddresses part of #9585 (comment).