fix(test): output parallel test results independently #15399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
reviewed
Aug 4, 2022
dsherret
reviewed
Aug 4, 2022
dsherret
approved these changes
Aug 4, 2022
There was a problem hiding this comment.
Thanks @nayeemrmn! Looks good to me. Will try to merge this before the release today.
dsherret
changed the title
|
Categorized this as a fix to get it in the patch release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently you get jumbled output for parallel tests with steps. This introduces a new formatting mode for
--parallelwhich outputs self-contained result lines:I've removed the
TestReportertrait, it's clear that it couldn't fulfil any purpose since the cli and lsp test runners needed different event loops in the first place.cc @lucacasonato