[CI] Integration tests through pytest #2109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanking520
reviewed
Jun 26, 2024
| ./start_instance.sh action_inf2 $token djl-serving | ||
| outputs: | ||
| gpu_instance_id: ${{ steps.create_gpu.outputs.action_gpu_instance_id }} | ||
| gpu_instance_id_1: ${{ steps.create_gpu.outputs.action_g6_instance_id }} |
There was a problem hiding this comment.
why do you want to merge all tests? This will make a lot of idle instances and make the pipeline hard to get to green
This combines the older integration test suite into the new pytest one. It uses the original integration action rather than the llm_integration one.
tosterberg
approved these changes
Jul 3, 2024
|
With regards to Qing's comment - I do agree that this will be harder to pass, but not significantly so when compared to the large model integration script that we are folding in here. Moving to a single script and then parting out to create specific "golden" passing workflows makes sense to me. Aside - this will remove the Large Model Inference from actions, so we will need to do a follow up CLI trigger on a release branch so that the action is still manually executable for release branches. I will do this post merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combines the older integration test suite into the new pytest one. It uses the original integration action rather than the llm_integration one.
Sample run: https://github.com/deepjavalibrary/djl-serving/actions/runs/9671865360