Automated PR: auto update snapshots #4877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
mfranzke,
nmerget and
michaelmkraus
as code owners
|
dbux-auto-merge-pr
bot
merged commit 2be03a4
into
4019-dbselect-dropdown-checkmark-on-first-element
dbux-auto-merge-pr
bot
deleted the
4019-dbselect-dropdown-checkmark-on-first-element-auto
branch
mfranzke
added a commit
that referenced
this pull request
Sep 1, 2025
…4020) * refactor: let's not hide the first element in the select anymore it's inconsistent in between browsers and we should only use it for placeholders or floating labels * Update packages/components/src/components/select/select.lite.tsx Co-authored-by: Copilot <[email protected]> * test: updated snapshots * test: updated snapshots * refactor: removed those again * test: updated snapshots * Revert "test: updated snapshots" This reverts commit 5c43e22. * Update DBSelect-should-have-same-aria-snapshot.yaml * Update DBSelect-should-have-same-aria-snapshot.yaml * Update DBSelect-should-have-same-aria-snapshot.yaml * test: updated snapshots * test: updated snapshot * refactor: updated snapshots * auto update snapshots (#4442) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * test: updated snapshots * auto update snapshots (#4453) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * refactor: prettifying * refactor: corrected aria snapshots * refactor: corrected aria snapshots * auto update snapshots (#4454) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * refactor: let's give this a try * auto update snapshots (#4455) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * test: updated snapshots * test: updated snapshots * Revert "refactor: let's give this a try" This reverts commit 49ca700. * Update index.html * auto update snapshots (#4456) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore: another try * auto update snapshots (#4457) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore: another try * Revert "chore: another try" This reverts commit 88cea12. * auto update snapshots (#4463) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * refactor: placeholder shouldn't be an empty string, elsewhere check for floating label * refactor: only display placeholder, not label at this place I can't come up with a good reason by we would want to have a redundant label get output here * refactor: regenerated package lock file * auto update snapshots (#4734) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update select.lite.tsx * fix: setting the placeholder by the children doesn't make any sense at all * auto update snapshots (#4738) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix: setting it by the name instead * refactor: this looks better now * auto update snapshots (#4739) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * refactor: optimization * refactor: let's give this a try * auto update snapshots (#4748) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update select.lite.tsx * auto update snapshots (#4750) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * refactor: aligned with base branch * auto update snapshots (#4758) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * refactor: we've introduced placeholder property data for this * auto update snapshots (#4764) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix(test): temporary fix for vue tests * refactor: reverted file from main * fix: corrected package lock files contents * Create eleven-balloons-whisper.md * Update packages/components/src/components/select/select.lite.tsx Co-authored-by: Copilot <[email protected]> * Update state description handling for placeholder * auto update snapshots (#4877) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Apply suggestions from code review * auto update snapshots (#4878) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Michael Kraus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created automatically by a GitHub Action.