Skip to content

refactor(select): not hiding the first option HTML element anymore #4020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 91 commits into from
Sep 1, 2025
Merged

refactor(select): not hiding the first option HTML element anymore #4020

merged 91 commits into from
Sep 1, 2025
+232 −46

Conversation

mfranzke
Copy link
Collaborator

@mfranzke mfranzke commented Apr 4, 2025 •
edited
Loading

Proposed changes

  • it's inconsistent in between browsers (Safari would still display that option[hidden])
  • it's inconsistent and incorrect for regular select-HTML-elements, as those would actually mark the first option as checked as well, whereas this is actually the selected one (gets transmitted in form submits etc.)
  • In case that somebody would like to use floating labels or placeholder, there should be an option that the users could set to "unselect" all selectable options, or in other words "reset" any other selection. We wouldn't provide this possibility at the moment anyhow.

Resolves #4019 and #3116

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke
refactor: let's not hide the first element in the select anymore
4eb469d 
it's inconsistent in between browsers and we should only use it for placeholders or floating labels
@mfranzke mfranzke requested a review from nmerget as a code owner April 4, 2025 09:16
@mfranzke mfranzke linked an issue Apr 4, 2025 that may be closed by this pull request
DBSelect dropdown checkmark on first element #4019
Closed
7 tasks
@mfranzke mfranzke self-assigned this Apr 4, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2025

🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/4019-dbselect-dropdown-checkmark-on-first-element

@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Apr 4, 2025
@github-actions github-actions bot added the 🧱components Changes inside components folder label Apr 4, 2025
@mfranzke mfranzke requested review from Copilot and removed request for nmerget April 4, 2025 09:16
@mfranzke mfranzke moved this to 🏗 In development in UX Engineering Team Backlog Apr 4, 2025
@mfranzke mfranzke added the 🐛bug Something isn't working label Apr 4, 2025
Copilot

This comment was marked as outdated.

Sign in to view

@mfranzke mfranzke added this to the 2.0.0 milestone Apr 4, 2025
@mfranzke mfranzke changed the title refactor: let's not hide the first element in the select anymore refactor(selector): let's not hide the first element in the select anymore Apr 4, 2025
@mfranzke mfranzke changed the title refactor(selector): let's not hide the first element in the select anymore refactor(selector): let's not hide the first element anymore Apr 4, 2025
@mfranzke mfranzke changed the title refactor(selector): let's not hide the first element anymore refactor(selector): let's not hide the first option anymore Apr 4, 2025
@mfranzke mfranzke changed the title refactor(selector): let's not hide the first option anymore refactor(selector): not hiding the first option anymore Apr 4, 2025
@mfranzke mfranzke modified the milestones: 2.0.0, 2.1.0 Apr 15, 2025
@github-actions github-actions bot added the 📦foundations Changes inside foundations folder label Apr 17, 2025
@mfranzke mfranzke changed the title refactor(selector): not hiding the first option HTML element anymore refactor(select): not hiding the first option HTML element anymore Aug 25, 2025
@github-actions github-actions bot added 📕documentation Improvements or additions to documentation 📺showcases Changes to 1-n showcases 🏘components labels Aug 29, 2025
michaelmkraus
michaelmkraus previously approved these changes Aug 29, 2025
View reviewed changes
@michaelmkraus michaelmkraus disabled auto-merge August 29, 2025 12:44
@mfranzke mfranzke moved this from 👀 In review to ready for release in UX Engineering Team Backlog Aug 29, 2025
@mfranzke mfranzke enabled auto-merge (squash) August 31, 2025 15:34
@mfranzke mfranzke disabled auto-merge August 31, 2025 18:17
@mfranzke mfranzke enabled auto-merge (squash) August 31, 2025 18:17
@mfranzke mfranzke disabled auto-merge August 31, 2025 18:30
mfranzke
mfranzke commented Sep 1, 2025
View reviewed changes
mfranzke
mfranzke commented Sep 1, 2025
View reviewed changes
mfranzke and others added 2 commits September 1, 2025 06:52
@mfranzke
Apply suggestions from code review
809f7d6
@github-actions
auto update snapshots (#4878)
0ba4996 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mfranzke mfranzke merged commit aebaaad into main Sep 1, 2025
57 checks passed
@mfranzke mfranzke deleted the 4019-dbselect-dropdown-checkmark-on-first-element branch September 1, 2025 06:30
@github-project-automation github-project-automation bot moved this from ready for release to ✅ Done in UX Engineering Team Backlog Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@michaelmkraus michaelmkraus michaelmkraus left review comments

Assignees
No one assigned
Labels
🐛bug Something isn't working 🧱components Changes inside components folder 🏘components 📕documentation Improvements or additions to documentation 🍄🆙improvement New feature or request 📺showcases Changes to 1-n showcases
Projects
Roadmap
Status: No status
UX Engineering Team Backlog
Status: ✅ Done
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

DBSelect dropdown checkmark on first element
2 participants
@mfranzke @michaelmkraus