Fix build and CI

[krassowski]

• Fixes This CI is broken #49
• Fixes Make pytest unit tests more robust #16

[github-actions]

👈 Launch a Binder on branch krassowski/jupyter-server-nbmodel/fix-build-and-ci

[krassowski]

Lint is failing:

Checking formatting...
[warn] package.json
[warn] README.md
[warn] src/plugin.ts
[warn] src/requestServer.ts
[warn] tsconfig.json
[warn] Code style issues found in 5 files. Run Prettier with --write to fix.

tsconfig.json is not valid json as trailing commas are not permitted, but this was added in #37

The package.json was reformatted in #37 too. I will just run jlpm lint and push a commit.

[krassowski]

And eslint was upgraded to v9 in #37 too (799c588) which does not work and would require a lot of work as it is a complete rewrite of eslint configuration system:

Oops! Something went wrong! :(

ESLint: 9.31.0

ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

From ESLint v9.0.0, the default configuration file is now eslint.config.js.
If you are using a .eslintrc.* file, please follow the migration guide
to update your configuration file to the new format:

Reverrting that change too

[krassowski]

Some tests are timing out (related to #16), one test needs updating assertions:

E       assert {'status': 'error', 'execution_count': 1, 'outputs': '[{"output_type": "error", "ename": "ZeroDivisionError", "evalue": "division by zero", "traceback": ["\\u001b[31m---------------------------------------------------------------------------\\u001b[39m", "\\u001b[31mZeroDivisionError\\u001b[39m                         Traceback (most recent call last)", "\\u001b[36mCell\\u001b[39m\\u001b[36m \\u001b[39m\\u001b[32mIn[1]\\u001b[39m\\u001b[32m, line 1\\u001b[39m\\n\\u001b[32m----> \\u001b[39m\\u001b[32m1\\u001b[39m \\u001b[32;43m1\\u001b[39;49m\\u001b[43m \\u001b[49m\\u001b[43m/\\u001b[49m\\u001b[43m \\u001b[49m\\u001b[32;43m0\\u001b[39;49m\\n", "\\u001b[31mZeroDivisionError\\u001b[39m: division by zero"]}]'} == {'status': 'error', 'execution_count': 1, 'outputs': '[{"output_type": "error", "ename": "ZeroDivisionError", "evalue": "division by zero", "traceback": ["\\u001b[0;31m---------------------------------------------------------------------------\\u001b[0m", "\\u001b[0;31mZeroDivisionError\\u
E         
E         Common items:
E         {'execution_count': 1, 'status': 'error'}
E         Differing items:
E         {'outputs': '[{"output_type": "error", "ename": "ZeroDivisionError", "evalue": "division by zero", "traceback": ["\\u0...001b[43m \\u001b[49m\\u001b[32;43m0\\u001b[39;49m\\n", "\\u001b[31mZeroDivisionError\\u001b[39m: division by zero"]}]'} != {'outputs': '[{"output_type": "error", "ename": "ZeroDivisionError", "evalue": "division by zero", "traceback": ["\\u0...m \\u001b[49m\\u001b[38;5;241;43m0\\u001b[39;49m\\n", "\\u001b[0;31mZeroDivisionError\\u001b[0m: division by zero"]}]'}
E         
E         Full diff:
E           {
E               'execution_count': 1,
E               'outputs': '[{"output_type": "error", "ename": "ZeroDivisionError", "evalue": '
E               '"division by zero", "traceback": '
E         -     '["\\u001b[0;31m---------------------------------------------------------------------------\\u001b[0m", '
E         ?                --                                                                                      ^
E         +     '["\\u001b[31m---------------------------------------------------------------------------\\u001b[39m", '
E         ?                                                                                                      ^^
E         -     '"\\u001b[0;31mZeroDivisionError\\u001b[0m                         '
E         ?               --                            ^
E         +     '"\\u001b[31mZeroDivisionError\\u001b[39m                         '
E         ?                                           ^^
E         -     'Traceback (most recent call last)", "Cell \\u001b[0;32mIn[1], line '
E         +     'Traceback (most recent call last)", '
E         +     '"\\u001b[36mCell\\u001b[39m\\u001b[36m '
E         +     '\\u001b[39m\\u001b[32mIn[1]\\u001b[39m\\u001b[32m, line '
E         -     '1\\u001b[0m\\n\\u001b[0;32m----> 1\\u001b[0m '
E         ?               ^            --                  ^
E         +     '1\\u001b[39m\\n\\u001b[32m----> \\u001b[39m\\u001b[32m1\\u001b[39m '
E         ?               ^^                     ++++++++++++++++++++++         ^^
E         -     '\\u001b[38;5;241;43m1\\u001b[39;49m\\u001b[43m '
E         ?               ---- --
E         +     '\\u001b[32;43m1\\u001b[39;49m\\u001b[43m '
E         -     '\\u001b[49m\\u001b[38;5;241;43m/\\u001b[39;49m\\u001b[43m '
E         ?                         ---------            ---
E         +     '\\u001b[49m\\u001b[43m/\\u001b[49m\\u001b[43m '
E         -     '\\u001b[49m\\u001b[38;5;241;43m0\\u001b[39;49m\\n", '
E         ?                          ---- --
E         +     '\\u001b[49m\\u001b[32;43m0\\u001b[39;49m\\n", '
E         -     '"\\u001b[0;31mZeroDivisionError\\u001b[0m: division by zero"]}]',
E         ?               --                            ^
E         +     '"\\u001b[31mZeroDivisionError\\u001b[39m: division by zero"]}]',
E         ?                                           ^^
E               'status': 'error',
E           }

[echarles]

Thx for taking care of this @krassowski and sorry for all the breakage...

CI is back green. Happy to merge if you think you are done with the repairs :)

[krassowski]

Yes, ready to go!

[echarles]

LGTM Thx @krassowski