Skip to content

Split javascript and python source files #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 21, 2025
Merged

Split javascript and python source files #37

merged 7 commits into from
May 21, 2025

Conversation

echarles
Copy link
Member

@echarles echarles commented May 20, 2025

This PR does not change the functionality, it just splits the javascript and python to make the source code more readable.

It also ensure the extension can be built with npm.

Copy link

Binder 👈 Launch a Binder on branch datalayer/jupyter-server-nbmodel/fix%2Fnpm

@echarles echarles changed the title Fix/npm Split javascript and python source files May 20, 2025
@echarles echarles requested a review from eleonorecharles May 20, 2025 11:48
@echarles echarles added refactor enhancement New feature or request labels May 20, 2025
@eleonorecharles eleonorecharles merged commit 73ee845 into main May 21, 2025
4 of 6 checks passed
@eleonorecharles eleonorecharles deleted the fix/npm branch May 21, 2025 07:06
This was referenced Jul 18, 2025
@krassowski
Copy link
Collaborator

Just a note that I would recommend releasing this in a new minor version because users will need manually update jupyter-server-nbmodel:notebook-cell-executor if they were disabling this plugin as it is now called @datalayer/jupyter-server-nbmodel:notebook-cell-executor (though it does not need to be - you could publish under @datalayer on npm without renaming the plugin).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants