Always use absolute path for --store option #1637

rhatdan · 2025-07-01T13:07:17Z

Fixes: #1634

Summary by Sourcery

Use absolute paths for the --store option to ensure consistent store directory resolution

Bug Fixes:

Normalize relative paths supplied to --store by converting them to absolute paths

Enhancements:

Introduce an abspath function and set it as the type converter for the --store argument in the CLI

Tests:

Add a system test for ramalama info --store to verify relative paths are translated to their absolute equivalents

sourcery-ai · 2025-07-01T13:07:22Z

Reviewer's Guide

This PR ensures the CLI always resolves the --store path to an absolute path by introducing an abspath converter and updating tests to validate the behavior.

Class diagram for abspath integration in CLI argument parsing

classDiagram
    class ArgumentParserWithDefaults {
        +add_argument()
    }
    class abspath {
        +__call__(astring)
    }
    ArgumentParserWithDefaults <.. abspath : uses

File-Level Changes

Change	Details	Files
Add helper to normalize store paths to absolute	Define abspath function wrapping os.path.abspath Use abspath as type converter for --store argument	`ramalama/cli.py`
Add system test verifying absolute path conversion	Introduce a Bats test running ramalama info with a relative path Assert the output Store value is the resolved absolute path	`test/system/060-info.bats`

Possibly linked issues

ramalama pull fails when --store flag is used #1634: The PR changes the --store option to use absolute paths, fixing the pull failure with relative paths described in the issue.

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

gemini-code-assist

Summary of Changes

Hello @rhatdan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where the --store option might not consistently resolve paths to their absolute form. The changes introduce a new utility function and integrate it into the command-line argument parsing, ensuring that all paths provided via --store are automatically converted to absolute paths. A new system test has also been added to verify this behavior, improving the robustness and predictability of path handling for the store option.

Highlights

Path Handling: Introduced a new abspath helper function in ramalama/cli.py (lines 151-152) to consistently convert paths to their absolute form using os.path.abspath.
CLI Argument Processing: Configured the --store command-line argument in ramalama/cli.py (line 229) to automatically use the new abspath function as its type converter, ensuring that any provided store path is always absolute.
Testing: Added a new system test case in test/system/060-info.bats (lines 62-65) to validate that the --store option correctly resolves relative paths (e.g., /tmp/../tmp/store) to their absolute counterparts (/tmp/store).

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

sourcery-ai

Hey @rhatdan - I've reviewed your changes - here's some feedback:

The abspath helper doesn’t expand user home (~) patterns – consider using os.path.expanduser or pathlib.Path(p).expanduser().resolve() to handle tilde before making it absolute.
Currently only CLI‐provided --store values get normalized; consider normalizing CONFIG.store in your configuration loader as well so that default or env‐set values are always absolute.

Prompt for AI Agents

Please address the comments from this code review:
## Overall Comments
- The abspath helper doesn’t expand user home (~) patterns – consider using os.path.expanduser or pathlib.Path(p).expanduser().resolve() to handle tilde before making it absolute.
- Currently only CLI‐provided --store values get normalized; consider normalizing CONFIG.store in your configuration loader as well so that default or env‐set values are always absolute.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

gemini-code-assist

Code Review

This pull request introduces an abspath function and applies it to the --store argument in the CLI to ensure consistent store directory resolution. The changes include a new test case to verify the correct translation of relative paths to absolute paths.

ramalama/cli.py

gemini-code-assist · 2025-07-01T13:09:42Z

test/system/060-info.bats

+      run_ramalama --store /tmp/../tmp/store info
+      actual=$(echo "$output" | jq -r ".Store")
+      is "$actual" "/tmp/store" "Verify relative paths translated to absolute path"


The test uses /tmp/../tmp/store, which is an absolute path. To properly test the conversion of relative paths to absolute paths, use a relative path instead.

run_ramalama --store ./tmp/store info actual=$(echo "$output" | jq -r ".Store") is "$actual" "$(pwd)/tmp/store" "Verify relative paths translated to absolute path"

ramalama/model_factory.py

engelmi

LGTM

It seems there are currently some infra issues for CentOS Stream 10, so nothing related to or blocking the PR.

Fixes: containers#1634 Signed-off-by: Daniel J Walsh <[email protected]>

rhatdan requested review from ericcurtin, bmahabirbu, maxamillion, swarajpande5, jhjaggars, cgruver and engelmi as code owners July 1, 2025 13:07

gemini-code-assist bot reviewed Jul 1, 2025

View reviewed changes

sourcery-ai bot approved these changes Jul 1, 2025

View reviewed changes

gemini-code-assist bot reviewed Jul 1, 2025

View reviewed changes

telemaco mentioned this pull request Jul 1, 2025

Ensure GlobalModelStore._store_base_path is an absolute path #1636

Closed

rhatdan force-pushed the store branch from e230e84 to 5843e38 Compare July 1, 2025 13:15

engelmi reviewed Jul 1, 2025

View reviewed changes

ramalama/model_factory.py Outdated Show resolved Hide resolved

rhatdan force-pushed the store branch from 5843e38 to 749f136 Compare July 1, 2025 13:19

engelmi approved these changes Jul 1, 2025

View reviewed changes

ericcurtin approved these changes Jul 1, 2025

View reviewed changes

rhatdan force-pushed the store branch from 749f136 to 1ef28d8 Compare July 2, 2025 10:31

Always use absolute path for --store option

6899554

Fixes: containers#1634 Signed-off-by: Daniel J Walsh <[email protected]>

rhatdan force-pushed the store branch from 1ef28d8 to 6899554 Compare July 3, 2025 10:39

ericcurtin approved these changes Jul 3, 2025

View reviewed changes

ericcurtin merged commit 06488b4 into containers:main Jul 3, 2025
15 of 25 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Always use absolute path for --store option #1637

Always use absolute path for --store option #1637

Uh oh!

rhatdan commented Jul 1, 2025 •

edited by sourcery-ai bot

Loading

Uh oh!

sourcery-ai bot commented Jul 1, 2025 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

sourcery-ai bot left a comment

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

gemini-code-assist bot Jul 1, 2025

Uh oh!

Uh oh!

engelmi left a comment

Uh oh!

Uh oh!

Uh oh!

Always use absolute path for --store option #1637

Always use absolute path for --store option #1637

Uh oh!

Conversation

rhatdan commented Jul 1, 2025 • edited by sourcery-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by Sourcery

Uh oh!

sourcery-ai bot commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

Class diagram for abspath integration in CLI argument parsing

File-Level Changes

Possibly linked issues

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

gemini-code-assist bot Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

engelmi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rhatdan commented Jul 1, 2025 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Jul 1, 2025 •

edited

Loading