Always use absolute path for --store option

Fixes: #1634

Signed-off-by: Daniel J Walsh <[email protected]>

Author: rhatdan

ramalama/cli.py

@@ -148,6 +148,10 @@ def get_description():
 """
 
 
+def abspath(astring):
+    return os.path.abspath(astring)
+
+
 def create_argument_parser(description: str):
     """Create and configure the argument parser for the CLI."""
     parser = ArgumentParserWithDefaults(
@@ -222,6 +226,7 @@ def configure_arguments(parser):
     parser.add_argument(
         "--store",
         default=CONFIG.store,
+        type=abspath,
         help="store AI Models in the specified directory",
     )
     parser.add_argument(

ramalama/model_factory.py

@@ -36,7 +36,7 @@ def __init__(
 
         self.pruned_model = self.prune_model_input()
         self.draft_model = None
-        if getattr(args, 'model_draft', None):
+        if hasattr(args, 'model_draft') and args.model_draft:
             dm_args = copy.deepcopy(args)
             dm_args.model_draft = None
             self.draft_model = ModelFactory(args.model_draft, dm_args, ignore_stderr=True).create()
@@ -63,7 +63,7 @@ def __init__(
     def detect_model_model_type(
         self,
     ) -> Tuple[type[Union[Huggingface, Ollama, OCI, URL]], Callable[[], Union[Huggingface, Ollama, OCI, URL]]]:
-        for prefix in ["huggingface://", "hf://", "hf.co/"]:
+        for prefix in ["huggingface://", "hfq://", "hf.co/"]:
             if self.model.startswith(prefix):
                 return Huggingface, self.create_huggingface
         for prefix in ["modelscope://", "ms://"]:
@@ -137,7 +137,7 @@ def create_oci(self) -> OCI:
     def create_url(self) -> URL:
         model = URL(self.pruned_model, self.store_path, urlparse(self.model).scheme)
         model.draft_model = self.draft_model
-        if getattr(self, 'split_model', None):
+        if hasattr(self, 'split_model'):
             model.split_model = self.split_model
             model.mnt_path = self.mnt_path
         return model

test/system/060-info.bats

@@ -59,4 +59,11 @@ Store   | $store
 
 }
 
+@test "ramalama info --store" {
+      store=$PWD/store
+      run_ramalama --store ./store info
+      actual=$(echo "$output" | jq -r ".Store")
+      is "$actual" "$store" "Verify relative paths translated to absolute path"
+}
+
 # vim: filetype=sh