Skip to content

Add dnf update -y to Fedora ROCm build #1544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025
+1 −0
Merged

Add dnf update -y to Fedora ROCm build #1544

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions container-images/scripts/build_llama_and_whisper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ dnf_install_cann() {
dnf_install_rocm() {
if [ "$containerfile" = "rocm" ]; then
if [ "${ID}" = "fedora" ]; then
dnf update -y
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Adding dnf update -y is a good step to ensure all packages are up-to-date, which can resolve compatibility or compiler issues, as intended by this PR. However, this command can significantly increase build times, especially if run frequently (e.g., with --no-cache builds).

To improve maintainability and help future developers understand the necessity of this potentially time-consuming step, please consider adding a brief comment explaining its purpose. If this addresses a specific, known compiler issue, referencing it (e.g., a link to an issue tracker or a brief description) would be very valuable.

This will help justify the build time increase and prevent accidental removal if the context is lost.

Suggested change
dnf update -y
# Update all system packages. This helps ensure that the latest package versions
# are installed, which can resolve potential compiler or compatibility issues
# before installing ROCm components on Fedora.
dnf update -y

dnf install -y rocm-core-devel hipblas-devel rocblas-devel rocm-hip-devel
else
add_stream_repo "AppStream"
Expand Down
Loading