Add dnf update -y to Fedora ROCm build #1544

ericcurtin · 2025-06-16T20:55:03Z

Trying to fix a compiler issue

Summary by Sourcery

Build:

Add dnf update -y step to the Fedora ROCm build script to update packages before installation

Trying to fix a compiler issue Signed-off-by: Eric Curtin <[email protected]>

sourcery-ai · 2025-06-16T20:55:07Z

Reviewer's Guide

Introduces a Fedora system update step before installing ROCm packages in the build script to ensure dependencies are current and resolve the reported compiler issue.

Flow diagram for updated Fedora ROCm build process

flowchart TD
    A[Start ROCm installation] --> B{Is containerfile 'rocm'?}
    B -- No --> C[Add AppStream repo]
    B -- Yes --> D{Is OS 'fedora'?}
    D -- No --> E[Proceed with non-Fedora ROCm install]
    D -- Yes --> F[Run 'dnf update -y']
    F --> G[Install ROCm packages]
    G --> H[Finish]
    C --> H
    E --> H

File-Level Changes

Change	Details	Files
Add system update step before installing ROCm dependencies on Fedora	Insert `dnf update -y` in the `dnf_install_rocm` function when `containerfile` is `rocm` and `ID` is `fedora`	`container-images/scripts/build_llama_and_whisper.sh`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

gemini-code-assist

Summary of Changes

Hello @ericcurtin, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a potential compiler issue during the Fedora ROCm build process by ensuring that the system's packages are fully updated prior to the installation of ROCm development libraries. This proactive step aims to improve the stability and success rate of the build by resolving potential dependency conflicts or outdated package issues.

Highlights

Build Process Enhancement: Introduced a dnf update -y command within the Fedora ROCm build script to ensure all system packages are up-to-date before installing ROCm development dependencies. This change specifically targets the dnf_install_rocm function when the container ID is 'fedora'.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

The pull request introduces a dnf update -y command within the Fedora ROCm build process in build_llama_and_whisper.sh. The goal is to update all system packages prior to installing ROCm, aiming to fix a compiler issue. This is a common strategy to ensure a stable and up-to-date environment.

My review includes one suggestion to add a comment explaining the rationale behind this update. This will enhance code clarity and maintainability, especially given that full system updates can impact build times.

gemini-code-assist · 2025-06-16T20:56:14Z

container-images/scripts/build_llama_and_whisper.sh

@@ -60,6 +60,7 @@ dnf_install_cann() {
 dnf_install_rocm() {
  if [ "$containerfile" = "rocm" ]; then
    if [ "${ID}" = "fedora" ]; then
+      dnf update -y


Adding dnf update -y is a good step to ensure all packages are up-to-date, which can resolve compatibility or compiler issues, as intended by this PR. However, this command can significantly increase build times, especially if run frequently (e.g., with --no-cache builds).

To improve maintainability and help future developers understand the necessity of this potentially time-consuming step, please consider adding a brief comment explaining its purpose. If this addresses a specific, known compiler issue, referencing it (e.g., a link to an issue tracker or a brief description) would be very valuable.

This will help justify the build time increase and prevent accidental removal if the context is lost.

Suggested change

dnf update -y

# Update all system packages. This helps ensure that the latest package versions

# are installed, which can resolve potential compiler or compatibility issues

# before installing ROCm components on Fedora.

dnf update -y

sourcery-ai

Hey @ericcurtin - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

ericcurtin · 2025-06-17T08:35:45Z

Seemed to build fine with this @rhatdan

rhatdan · 2025-06-17T09:00:02Z

LGTM

Add dnf update -y to Fedora ROCm build

65a0892

Trying to fix a compiler issue Signed-off-by: Eric Curtin <[email protected]>

ericcurtin requested review from rhatdan, bmahabirbu, maxamillion, swarajpande5, jhjaggars, cgruver, slp and engelmi as code owners June 16, 2025 20:55

gemini-code-assist bot reviewed Jun 16, 2025

View reviewed changes

sourcery-ai bot approved these changes Jun 16, 2025

View reviewed changes

rhatdan merged commit 9e2ef6f into main Jun 17, 2025
14 of 16 checks passed

ericcurtin deleted the add-dnf-update branch June 18, 2025 23:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add dnf update -y to Fedora ROCm build #1544

Add dnf update -y to Fedora ROCm build #1544

Uh oh!

ericcurtin commented Jun 16, 2025 •

edited by sourcery-ai bot

Loading

Uh oh!

sourcery-ai bot commented Jun 16, 2025 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Jun 16, 2025

Uh oh!

sourcery-ai bot left a comment

Uh oh!

ericcurtin commented Jun 17, 2025

Uh oh!

rhatdan commented Jun 17, 2025

Uh oh!

Uh oh!

Uh oh!

-      dnf update -y
+      # Update all system packages. This helps ensure that the latest package versions
+      # are installed, which can resolve potential compiler or compatibility issues
+      # before installing ROCm components on Fedora.
+      dnf update -y

Add dnf update -y to Fedora ROCm build #1544

Add dnf update -y to Fedora ROCm build #1544

Uh oh!

Conversation

ericcurtin commented Jun 16, 2025 • edited by sourcery-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by Sourcery

Uh oh!

sourcery-ai bot commented Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

Flow diagram for updated Fedora ROCm build process

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

ericcurtin commented Jun 17, 2025

Uh oh!

rhatdan commented Jun 17, 2025

Uh oh!

Uh oh!

Uh oh!

ericcurtin commented Jun 16, 2025 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Jun 16, 2025 •

edited

Loading