:latest tag should not be assumed for non-OCI artefacts

[ericcurtin]

I see people showing things like:

file://srv/llm/modles/unsloth/Qwen3-235B-A22B-GGUF/UD_Q2_K_XL/Qwen3-235B-A22B-UD-Q2_K_XL-00001-of-00002.gguf:latest 1 month ago  46.42 GB file://srv/llm/modles/unsloth/Qwen3-235B-A22B-GGUF/UD_Q2_K_XL/Qwen3-235B-A22B-UD-Q2_K_XL-00002-of-00002.gguf:latest 1 month ago  35.55 GB
file://srv/llm/modles/unsloth/Qwen3-235B-A22B-GGUF/Q8_0/Qwen3-235B-A22B-Q8_0-00001-of-00006.gguf:latest             1 week ago   46.44 GB
file://srv/llm/modles/unsloth/Qwen3-235B-A22B-GGUF/Q8_0/Qwen3-235B-A22B-Q8_0-00002-of-00006.gguf:latest             1 week ago   46.0 GB
file://srv/llm/modles/unsloth/Qwen3-235B-A22B-GGUF/Q8_0/Qwen3-235B-A22B-Q8_0-00003-of-00006.gguf:latest             1 week ago   45.93 GB
file://srv/llm/modles/unsloth/Qwen3-235B-A22B-GGUF/Q8_0/Qwen3-235B-A22B-Q8_0-00004-of-00006.gguf:latest             1 week ago   46.0 GB
file://srv/llm/modles/unsloth/Qwen3-235B-A22B-GGUF/Q8_0/Qwen3-235B-A22B-Q8_0-00005-of-00006.gguf:latest             1 week ago   46.0 GB
file://srv/llm/modles/unsloth/Qwen3-235B-A22B-GGUF/Q8_0/Qwen3-235B-A22B-Q8_0-00006-of-00006.gguf:latest             1 week ago   2.39 GB

Summary by Sourcery

Enhancements:

• Only remove the ':latest' suffix for model references that are not using the ollama:// or oci:// schemes

[sourcery-ai]

Reviewer's Guide

In the CLI’s model-listing routine, the code now retains the “:latest” tag for Ollama and OCI URIs by wrapping the suffix removal in a guard that only applies to other schemes (after the existing Hugging Face URL normalization).

Flow diagram for model URI normalization and :latest tag handling

flowchart TD
    A[Start: model URI] --> B{model starts with 'huggingface://'?}
    B -- Yes --> C[Replace 'huggingface://' with 'hf://']
    B -- No --> D
    C --> D{model starts with 'ollama://' or 'oci://'?}
    D -- Yes --> E[Do not remove ':latest']
    D -- No --> F[Remove ':latest' suffix]
    E --> G[Continue processing]
    F --> G
    D --> G

Loading

File-Level Changes

Change	Details	Files
Conditional stripping of ":latest" suffix based on URI scheme	Add guard to skip suffix removal for Ollama and OCI schemes Move the removesuffix call inside the new conditional	ramalama/cli.py

Possibly linked issues

• Resolve undefined errors in huggingface.py and model.py #123: The PR fixes the invalid reference error for local paths by correctly handling non-OCI references, not assuming a ':latest' tag.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[ericcurtin]

@engelmi PTAL

[gemini-code-assist]

Summary of Changes

Hello @ericcurtin, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request fixes an issue where the :latest tag was being incorrectly removed from model identifiers that are not OCI or Ollama specific. The change updates the model string processing to preserve the :latest tag for OCI and Ollama schemes while continuing to remove it for others like local files.

Highlights

• Conditional Suffix Removal: Modified the logic in _list_models_from_store to conditionally remove the :latest suffix from model identifiers.
• Scheme-Specific Handling: The :latest suffix is now only removed if the model identifier does not start with ollama:// or oci://. This means it will still be removed for schemes like file:// or hf://.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request modifies the _list_models_from_store function in ramalama/cli.py to avoid removing the :latest suffix from model references that use the ollama:// or oci:// schemes. This prevents the tool from incorrectly assuming the :latest tag for non-OCI artifacts.

[sourcery-ai]

Hey @ericcurtin - I've reviewed your changes - here's some feedback:

• If file:// URIs should also preserve the :latest suffix, include file:// in the exclusion list here.
• You can simplify the negative check by using if not model.startswith(("ollama://", "oci://")) instead of two separate startswith calls.

Prompt for AI Agents

Please address the comments from this code review:
## Overall Comments
- If file:// URIs should also preserve the `:latest` suffix, include `file://` in the exclusion list here.
- You can simplify the negative check by using `if not model.startswith(("ollama://", "oci://"))` instead of two separate `startswith` calls.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[rhatdan]

LGTM
But tests are not happy.

[ericcurtin]

Yeah... Will get to them

[engelmi]

LGTM

[rhatdan]

LGTM