Skip to content

Conversation

swarajpande5
Copy link
Collaborator

Resolves some undefined errors I found while exploring the codebase.

@ericcurtin
Copy link
Member

We need more CI for this kinda thing, that's for sure

@ericcurtin ericcurtin merged commit 734bb6b into containers:main Sep 6, 2024
3 checks passed
@swarajpande5
Copy link
Collaborator Author

@ericcurtin Definitely, flake8 could help in this, however flake8 might collide with autopep8 being used.

@ericcurtin
Copy link
Member

SGTM, opened an issue so we can get to it at some point:

#125

I'm all for adding these tools, unless they start to make our builds unreasonably unstable, but we can always turn any of these tools off again if that happens.

@swarajpande5 swarajpande5 deleted the fix branch September 6, 2024 15:33
This was referenced May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants