Skip to content

Conversation

jasnell
Copy link
Collaborator

@jasnell jasnell commented Aug 24, 2025

Update api/streams to use checked-queue... the checked-queue is safer as it has better guards around accidental use of invalid bare references

builds on #4879

@jasnell jasnell requested review from a team as code owners August 24, 2025 15:30
@jasnell jasnell force-pushed the jasnell/checked-queue-2 branch 3 times, most recently from a5cbfeb to 43d8b61 Compare August 25, 2025 21:40
Base automatically changed from jasnell/checked-queue to main August 25, 2025 22:23
@jasnell jasnell force-pushed the jasnell/checked-queue-2 branch from 43d8b61 to 335ae18 Compare August 25, 2025 22:29
@jasnell jasnell requested a review from npaun August 25, 2025 22:33
Copy link
Member

@npaun npaun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I suggest we have two reviews on this one cause streams.

@jasnell jasnell merged commit 1177808 into main Aug 27, 2025
21 checks passed
@jasnell jasnell deleted the jasnell/checked-queue-2 branch August 27, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants