-
Notifications
You must be signed in to change notification settings - Fork 435
Implementing workerd::util::Queue<T> #4879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A wrapper around an std::list that implements safety checks to ensure that queue queue is not accessed incorrectly.
da6e1bd
to
d0d8a6e
Compare
npaun
reviewed
Aug 25, 2025
npaun
reviewed
Aug 25, 2025
Co-authored-by: Nicholas Paun <[email protected]>
npaun
reviewed
Aug 25, 2025
Co-authored-by: Nicholas Paun <[email protected]>
npaun
reviewed
Aug 25, 2025
jasnell
commented
Aug 25, 2025
npaun
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scratching a long-time itch... implements a
workerd::util::Queue<T>
class that wrapsstd::list
with a safer interface. Whereasstd::list
front()
can be called without safety checks when the list is empty, returning a bad reference, theQueue<T>
will return akj::none
when the queue is empty. A few other details:kj::Maybe<T&>
but overall the design should be safer.This PR converts a number of the existing
std::list
uses. There are more to do, particularly inapi/streams
but I'll update those separately.The whole motivation here is to have a safer-to-use alternative to standard containers.