-
-
Notifications
You must be signed in to change notification settings - Fork 68
policy: Use source pod's egress policy if available #1172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofstetter
approved these changes
Feb 19, 2025
b08bc22
to
030d6dc
Compare
Builder image appears broken, apt is crashing on libc update. Adding clang-tidy to to the builder image to cause a new one be built & we need it soon anyway. |
982bd3f
to
db08b11
Compare
db08b11
to
9ff905c
Compare
9ff905c
to
fef3998
Compare
sayboras
approved these changes
Feb 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Touch base offline for some points I don't understand, thanks ✅
Enforce source pod's egress policy, if available, i.e., when the source is a local pod, even in the north/south scenario, where the Ingress IP is used as the upstream source address. Signed-off-by: Jarno Rajahalme <[email protected]>
fef3998
to
21494ef
Compare
Removed stray comment. |
sayboras
added a commit
to cilium/cilium
that referenced
this pull request
Mar 7, 2025
Relates: cilium/proxy#1172 Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to cilium/cilium
that referenced
this pull request
Mar 7, 2025
This test will cover both positive and negative cases: - Request from any client pods to cilium-ingress-same-node will be allowed. - Request from any client pods to cilium-ingress-other-node will be denied. Relates: cilium/proxy#1172 Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to cilium/cilium
that referenced
this pull request
Mar 7, 2025
This test will cover both positive and negative cases: - Request from any client pods to cilium-ingress-same-node will be allowed. - Request from any client pods to cilium-ingress-other-node will be denied. Relates: cilium/proxy#1172 Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to cilium/cilium
that referenced
this pull request
Mar 7, 2025
This test will cover both positive and negative cases: - Request from any client pods to cilium-ingress-same-node will be allowed. - Request from any client pods to cilium-ingress-other-node will be denied. Relates: cilium/proxy#1172 Signed-off-by: Tam Mach <[email protected]>
github-merge-queue bot
pushed a commit
to cilium/cilium
that referenced
this pull request
Mar 12, 2025
This test will cover both positive and negative cases: - Request from any client pods to cilium-ingress-same-node will be allowed. - Request from any client pods to cilium-ingress-other-node will be denied. Relates: cilium/proxy#1172 Signed-off-by: Tam Mach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforce source pod's egress policy, if available, i.e., when the source is a local pod, even in the north/south scenario, where the Ingress IP is used as the upstream source address.