docker: Add clang-tidy-17 to builder deps

Add clang-tidy-17 to the builder image.

Signed-off-by: Jarno Rajahalme <[email protected]>

Author: jrajahalme

.github/workflows/build-envoy-image-ci.yaml

@@ -17,7 +17,7 @@ jobs:
   build-and-push-prs:
     timeout-minutes: 360
     name: Build and push multi-arch images
-    runs-on: ubuntu-latest-64-cores-256gb
+    runs-on: ubuntu-22.04-64-cores-256gb
     steps:
       - name: Set up Docker Buildx
         uses: docker/setup-buildx-action@f7ce87c1d6bead3e36075b2ce75da1f6cc28aaca # v3.9.0

Dockerfile.builder

@@ -1,8 +1,6 @@
 #
-# Builder dependencies. This takes a long time to build from scratch!
-# Also note that if build fails due to C++ internal error or similar,
-# it is possible that the image build needs more RAM than available by
-# default on non-Linux docker installs.
+# Builder dependencies.
+#
 FROM docker.io/library/ubuntu:22.04@sha256:ed1544e454989078f5dec1bfdabd8c5cc9c48e0705d07b678ab6ae3fb61952d2 AS base
 LABEL maintainer="[email protected]"
 ARG TARGETARCH
@@ -13,9 +11,10 @@ ENV TZ=Etc/UTC
 ENV GO_VERSION=1.23.6
 
 RUN ln -snf /usr/share/zoneinfo/$TZ /etc/localtime && echo $TZ > /etc/timezone
-RUN apt-get update && \
-    apt-get upgrade -y --no-install-recommends && \
-    apt-get install -y --no-install-recommends \
+RUN echo 'debconf debconf/frontend select Noninteractive' | debconf-set-selections && \
+    apt-get update -y -q && \
+    apt-get upgrade -y -q --no-install-recommends && \
+    apt-get install -y -q --no-install-recommends \
       ca-certificates \
       # Multi-arch cross-compilation packages
       gcc-aarch64-linux-gnu g++-aarch64-linux-gnu libc6-dev-arm64-cross binutils-aarch64-linux-gnu \
@@ -28,9 +27,9 @@ RUN apt-get update && \
       software-properties-common && \
     wget -qO- https://apt.llvm.org/llvm-snapshot.gpg.key | tee /etc/apt/trusted.gpg.d/apt.llvm.org.asc && \
     apt-add-repository -y "deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-17 main" && \
-    apt-get update && \
-    apt-get install -y --no-install-recommends \
-      clang-17 clang-tools-17 llvm-17-dev lldb-17 lld-17 clang-format-17 libc++-17-dev libc++abi-17-dev && \
+    apt-get update -y -q && \
+    apt-get install -y -q --no-install-recommends \
+      clang-17 clang-tidy-17 clang-tools-17 llvm-17-dev lldb-17 lld-17 clang-format-17 libc++-17-dev libc++abi-17-dev && \
     apt-get purge --auto-remove && \
     apt-get clean && \
     rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*