Skip to content

CLI: Support defineMain in main.ts #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

CLI: Support defineMain in main.ts #1170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e43bbc6
Update storybook to 8.6
kasperpeulen Apr 3, 2025
1c9920a
Improve coverage
kasperpeulen Apr 3, 2025
c133105
Ignore test-stories from coverage
kasperpeulen Apr 3, 2025
b78c053
Externalize prettier
kasperpeulen Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions node-src/tasks/report.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,4 +100,16 @@ describe('generateRport', () => {
path.join(__dirname, '../../chromatic-build-1.xml')
);
});

it('skips report generation when junitReport is false', async () => {
const ctx = {
client,
log: { ...log, debug: vi.fn() },
options: { junitReport: false },
build,
} as any;
await generateReport(ctx);
expect(ctx.log.debug).toHaveBeenCalledWith('junit report not configured, skipping');
expect(reportBuilder.writeTo).not.toHaveBeenCalled();
});
});
10 changes: 5 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,12 +107,12 @@
"@sentry/cli": "^2.37.0",
"@sentry/node": "^8.30.0",
"@snyk/dep-graph": "^2.9.0",
"@storybook/addon-essentials": "^8.1.5",
"@storybook/addon-essentials": "^8.6.12",
"@storybook/addon-webpack5-compiler-swc": "^1.0.3",
"@storybook/csf-tools": "^8.1.5",
"@storybook/csf-tools": "^8.6.12",
"@storybook/linter-config": "^4.0.0",
"@storybook/react": "^8.1.5",
"@storybook/react-webpack5": "^8.1.5",
"@storybook/react": "^8.6.12",
"@storybook/react-webpack5": "^8.6.12",
"@tsconfig/node16": "^16.1.1",
"@types/archiver": "^5.3.1",
"@types/async-retry": "^1.4.3",
Expand Down Expand Up @@ -193,7 +193,7 @@
"snyk-nodejs-lockfile-parser": "^1.58.18",
"snyk-nodejs-plugin": "^1.4.3",
"sort-package-json": "1.50.0",
"storybook": "^8.1.5",
"storybook": "^8.6.12",
"string-argv": "^0.3.1",
"strip-ansi": "^7.1.0",
"tmp-promise": "3.0.2",
Expand Down
1 change: 1 addition & 0 deletions tsup.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ export default defineConfig((options) => [
sourcemap: true,
clean: true,
platform: 'node',
external: ['prettier'],
target: 'node16', // Storybook still supports Node 16
env: {
SENTRY_ENVIRONMENT: process.env.CI ? 'production' : 'development',
Expand Down
1 change: 1 addition & 0 deletions vitest.config.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ export default defineConfig({
exclude: [
'vitest.no-threads.config.ts',
'scripts/**',
'test-stories/**',
'**/*.stories.{t,j}s',
...coverageConfigDefaults.exclude,
],
Expand Down
Loading