-
Notifications
You must be signed in to change notification settings - Fork 75
CLI: Support defineMain in main.ts #1170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📦 Package Size: 9260 KB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1170 +/- ##
==========================================
+ Coverage 70.19% 71.24% +1.04%
==========================================
Files 203 197 -6
Lines 7385 7191 -194
Branches 1308 1298 -10
==========================================
- Hits 5184 5123 -61
+ Misses 2178 2050 -128
+ Partials 23 18 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fdac41f
to
1c9920a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
Description
This PR bumps storybook csf tools, so that defineMain is allowed in
main.js/ts
.Manual QA
I build the package locally using the changes from this PR, and I noted a file size increase:
The move to prebundle all our deps in storybook, is kind of working against us in this case.
We kind of expect packages to have storybook as a peer dep, but that is not possible in chromatic cli because of:
This causes a 3MB increase, as babel gets now both prebundled in storybook and chromatic.
I did find that we do things a bit smarter in storybook 9 which would cause only a 0.5MB increase.
Storybook 9 is not stable yet, so we should bump the dep again in a couple of weeks, to get the bundle size back again.
📦 Published PR as canary version:
11.28.1--canary.1170.14246439837.0
✨ Test out this PR locally via: