-
Notifications
You must be signed in to change notification settings - Fork 148
fix: avoid running cachedir mount commands via script #2070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: egibs <[email protected]>
I think this is the right approach, but it seems possible in the future that we'd have potentially other setup commands to run outside of the chroot environment under |
Signed-off-by: egibs <[email protected]>
e.g.,
|
Signed-off-by: egibs <[email protected]>
…uard-dev#2070)" This reverts commit 4e7b2c4.
…2096) * Revert "fix: avoid running cachedir mount commands via script (#2070)" This reverts commit 4e7b2c4. * Revert "fix: avoid SSH lockups, use script for tests (#2049)" This reverts commit 7499c54. * With the change for script usage reverted, we need to fix the release data collection. Signed-off-by: Łukasz 'sil2100' Zemczak <[email protected]> --------- Signed-off-by: Łukasz 'sil2100' Zemczak <[email protected]>
We currently run all QEMU commands via
script
when running tests which does not work for the cache directory mount commands:This PR avoids running the initial
StartPod
commands viascript
while leaving all of the test pipelines unaltered.That said,
script
is now causing certain test commands to hang, so we'll have to follow up on that in a separate PR.