feat: return sdk response with more fields inc the signer #6036
Conversation
|
| ErrorLog string | ||
| Codespace string | ||
| GasWanted int64 | ||
| GasUsed int64 |
There was a problem hiding this comment.
do we want to add signer in the execution error as well?
Created the v2 wrapper @evan-forbes feel free to take a look at my approach. Once we bump the SDK I'll take another pass thru and open the PR. |
ninabarbakadze
requested review from
evan-forbes,
rach-id and
rootulp
as code owners
| defaultTmConfig := testnode.DefaultTendermintConfig() | ||
| defaultTmConfig.Mempool.TTLNumBlocks = ttlNumBlocks |
There was a problem hiding this comment.
[nit] this isn't the defaultTmConfig any more if the function overrides a variable
| defaultTmConfig := testnode.DefaultTendermintConfig() | |
| defaultTmConfig.Mempool.TTLNumBlocks = ttlNumBlocks | |
| tmConfig := testnode.DefaultTendermintConfig() | |
| tmConfig.Mempool.TTLNumBlocks = ttlNumBlocks |
| defaultBlobParams := blobtypes.DefaultParams() | ||
| defaultBlobParams.GovMaxSquareSize = squareSize |
There was a problem hiding this comment.
[nit] same, no longer the default
| defaultBlobParams := blobtypes.DefaultParams() | |
| defaultBlobParams.GovMaxSquareSize = squareSize | |
| blobParams := blobtypes.DefaultParams() | |
| blobParams.GovMaxSquareSize = squareSize |
| WithModifiers(genesis.SetBlobParams(enc.Codec, defaultBlobParams)) | ||
| // WithSuppressLogs(false) | ||
|
|
||
| testnodeConfig.Genesis.ConsensusParams.Block.MaxBytes = blocksize |
There was a problem hiding this comment.
[question] is it not possible to override this via a With___ function after testnode.DefaultConfig()?
| // NewTxClient creates a new v2 TxClient wrapper around the provided TxClient | ||
| func NewTxClient(client *user.TxClient) *TxClient { | ||
| return &TxClient{ | ||
| TxClient: client, | ||
| } | ||
| } |
There was a problem hiding this comment.
could we wrap the new function as well so the creator doesn't have to create v1 then wrap?
so
package v2
func New(args) {
v1.New(args)
etc
Overview
Fixes #5945
Fixes #5992