Refactor the TxClient to return TxResponse from the sdk

[evan-forbes]

instead of reuturing our own type and throwing away data such as gas used etc, we can return TxResponse.

this would involve expanding the struct in the sdk to include the signer celestiaorg/cosmos-sdk#683

this would be a breaking change, therefore would warrant a v2 of TxClient

[ninabarbakadze]

I guess a less breaking way would be to extend our own type to have all the other response fields and we would populate them.

[evan-forbes]

true, the thinking here was not to break celestia-node, which recreates a cosmos-sdk response from the txresponse type here

that's why the thinking here was to create a v2 of txclient and change this type

[ninabarbakadze]

I see. Yeah, we could do that.

[ninabarbakadze]

As I mentioned during sync with @evan-forbes the reason why we're returning custom response is because calling GetTx which returns sdk TxResponse requires kv indexing to be enabled which is pretty heavy for node operators and we've explicitly moved on from it.

[ninabarbakadze]

After looking into Celestia node I can see that they are not querying consensus node by calling GetTx to return SDK response. They just populate it with user.TxResponse only to avoid breaking the API. https://github.com/celestiaorg/celestia-node/blob/10737b8f7994c9a3806b957c95ce197e9916b26e/state/core_access.go#L582

Since we do not want to use kv indexing we can just increase the number of fields we return to the user in TxStatus in core with further info like GasWanted and GasUsed which can later be populated by node. Issues tracking the work are celestiaorg/celestia-core#2542 and #5992