Fix formatter comment reordering inside euid and on if-then-else #861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Kastner <[email protected]>
shaobo-he-aws
approved these changes
May 10, 2024
|
It'd great if we can update the fuzzing target to test that there are no reorderings. |
Found the |
aaronjeline
approved these changes
May 13, 2024
| Cargo.lock | ||
| Cargo.lock | ||
|
|
||
| # Generated by `insta` on failing test case. Should run `cargo insta review` |
There was a problem hiding this comment.
see #856
andrewmwells-amazon
approved these changes
May 13, 2024
khieta
pushed a commit
that referenced
this pull request
May 15, 2024
Signed-off-by: John Kastner <[email protected]>
shaobo-he-aws
pushed a commit
that referenced
this pull request
May 21, 2024
Signed-off-by: John Kastner <[email protected]>
shaobo-he-aws
pushed a commit
that referenced
this pull request
May 21, 2024
Signed-off-by: John Kastner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fix #787 and a similar comment reordering issue I found for if-then-else expressions.
Based on the existing tests and some time running the
formatterfuzz target locally, I'm fairly confident that not addingend_commentinVariableDefwon't break anything, but review is of course appreciated.As a side effect of the
VariableDefchange, a line break is introduced in the policy scope for some policies in test.cedar. I don't understand how that was introduced, but I'm willing to accept it.Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy(e.g., addition of a new API).I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):