Assert that comments are not reordered by formatter #318
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The formatter fuzz target only checked that all comments in the original policy were present in the output without checking that they appeared in the same order. This allowed cedar-policy/cedar#787 to exist. The fuzz target with the new, stronger, assertion passed local fuzzing after applying the fixes in cedar-policy/cedar#861.
As a pleasant side effect, it's actually more efficient to check for the comments in the order they were inserted than in an arbitrary order. The check is now a single linear scan rather than a linear scan for each comment, likely resolving the slow units noted in #268. The slow input in that issue is improved from 16 second to about 4 seconds.