Refactoring in integration testing code #707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kesha Hietala <[email protected]>
Signed-off-by: Kesha Hietala <[email protected]>
Signed-off-by: Andrew Wells <[email protected]> Signed-off-by: Kesha Hietala <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Kesha Hietala <[email protected]>
Signed-off-by: Yuan Lyu <[email protected]> Signed-off-by: Kesha Hietala <[email protected]>
Signed-off-by: Kesha Hietala <[email protected]>
Signed-off-by: Kesha Hietala <[email protected]>
Signed-off-by: Shaobo He <[email protected]> Signed-off-by: Kesha Hietala <[email protected]>
… CI (#692) Signed-off-by: Nick Szegheo <[email protected]> Signed-off-by: Kesha Hietala <[email protected]>
Signed-off-by: John Kastner <[email protected]> Signed-off-by: Kesha Hietala <[email protected]>
Signed-off-by: Shaobo He <[email protected]> Signed-off-by: Kesha Hietala <[email protected]>
Signed-off-by: John Kastner <[email protected]> Signed-off-by: Kesha Hietala <[email protected]>
Signed-off-by: Craig Disselkoen <[email protected]> Signed-off-by: Kesha Hietala <[email protected]>
Signed-off-by: Kesha Hietala <[email protected]>
Signed-off-by: Kesha Hietala <[email protected]>
Signed-off-by: Kesha Hietala <[email protected]>
khieta
force-pushed
the
khieta/use-new-integration-tests
branch
from
9b0bc5a to
a50e783
Compare
Signed-off-by: Kesha Hietala <[email protected]>
2 tasks
andrewmwells-amazon
approved these changes
Mar 8, 2024
|
PR to fix CedarDRT build failure is in cedar-spec#250. The SemVer failure is expected since this PR requires a major version bump. |
shaobo-he-aws
approved these changes
Mar 8, 2024
john-h-kastner-aws
approved these changes
Mar 8, 2024
|
|
||
| /// Simple wrapper around u128 to remind ourselves that timing info is in microseconds. | ||
| #[derive(Debug, Deserialize)] | ||
| pub struct Micros(pub u128); |
There was a problem hiding this comment.
Would it make sense to just directly store the Duration?
There was a problem hiding this comment.
This same type is used by the Lean FFI, so it makes it easier to just store the u128.
khieta
added a commit
that referenced
this pull request
Mar 11, 2024
Signed-off-by: Kesha Hietala <[email protected]>
3 tasks
This was referenced May 2, 2024
john-h-kastner-aws
pushed a commit
that referenced
this pull request
May 7, 2024
Signed-off-by: Kesha Hietala <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Some refactoring in preparation to move the integration tests to their own repository. This PR has the edits I wanted to make in #632, but closed to avoid potentially breaking users. As suggested by @andrewmwells-amazon, I left the current testing code in
cedar-policyunchanged (marking it as "deprecated") and made a newcedar-testingcrate to use moving forward.The
cedar-testingcrate will be treated like our other internal crates (e.g.,cedar-policy-core) in the sense that we may make changes without respecting semver.Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy(e.g., addition of a new API).I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):cedar-spec, and how you have tested that your updates are correct.)Disclaimer
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.