Skip to content

Conversation

0x00A5
Copy link
Contributor

@0x00A5 0x00A5 commented Mar 1, 2024

Description of changes

#636

Checklist for requesting a review

The change in this PR is (choose one, and delete the other options):

  • A breaking change requiring a major version bump to cedar-policy (e.g., changes to the signature of an existing API).
  • A backwards-compatible change requiring a minor version bump to cedar-policy (e.g., addition of a new API).
  • A bug fix or other functionality change requiring a patch to cedar-policy.
  • A change "invisible" to users (e.g., documentation, changes to "internal" crates like cedar-policy-core, cedar-validator, etc.)
  • A change (breaking or otherwise) that only impacts unreleased or experimental code.

I confirm that this PR (choose one, and delete the other options):

  • Updates the "Unreleased" section of the CHANGELOG with a description of my change (required for major/minor version bumps).
  • Does not update the CHANGELOG because my change does not significantly impact released code.

I confirm that cedar-spec (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar formal model or DRT infrastructure.
  • Requires updates, and I have made / will make these updates myself. (Please include in your description a timeline or link to the relevant PR in cedar-spec, and how you have tested that your updates are correct.)
  • Requires updates, but I do not plan to make them in the near future. (Make sure that your changes are hidden behind a feature flag to mark them as experimental.)
  • I'm not sure how my change impacts cedar-spec. (Post your PR anyways, and we'll discuss in the comments.)

Disclaimer

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@0x00A5 0x00A5 force-pushed the issue-636-entity-into-inner branch from 72942c1 to 8a1d74f Compare March 1, 2024 21:21
@shaobo-he-aws
Copy link
Contributor

@0x00A5 Thank you for your contribution. We recently require contributors of cedar-policy to sign-off their commits. Could you rebase your PR with sign-off once it's ready for merge?

@0x00A5 0x00A5 force-pushed the issue-636-entity-into-inner branch from 8a1d74f to a92ab85 Compare March 4, 2024 19:22
@0x00A5
Copy link
Contributor Author

0x00A5 commented Mar 4, 2024

Thanks for reviewing @shaobo-he-aws . I have rebased and amended my commit with sign-off message.

@shaobo-he-aws shaobo-he-aws merged commit c5dae1a into cedar-policy:main Mar 4, 2024
khieta pushed a commit that referenced this pull request Mar 8, 2024
Signed-off-by: Yuan Lyu <[email protected]>
Signed-off-by: Kesha Hietala <[email protected]>
shaobo-he-aws pushed a commit that referenced this pull request May 3, 2024
john-h-kastner-aws pushed a commit that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants