Skip to content

Cherrypick a bunch of PRs to release/4.5.x #1674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jun 26, 2025
Merged

Cherrypick a bunch of PRs to release/4.5.x #1674

merged 19 commits into from
Jun 26, 2025

Conversation

cdisselkoen
Copy link
Contributor

Cherry-picks the following PRs to release/4.5.x: (note that release/4.5.x started at 40be99c and thus automatically includes everything that hit main prior to #1624)

shaobo-he-aws and others added 18 commits June 26, 2025 10:21
@shaobo-he-aws @cdisselkoen
Make typed expression generation consistent with Lean (#1625)
bc3561e 
Signed-off-by: Shaobo He <[email protected]>
@shaobo-he-aws @cdisselkoen
Replace criterion::black_box with std::hint::black_box (#1630)
ccca390 
Signed-off-by: Shaobo He <[email protected]>
@dependabot @cdisselkoen
Bump the rust-dependencies group with 6 updates (#1628)
2d0ce0d 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@katherine-hough @cdisselkoen
Reverted downgrade of grcov (#1631)
e3c8318 
Signed-off-by: Katherine Hough <[email protected]>
@Swolebrain @cdisselkoen
Create policy set splitting functionality (#1629)
0b78323 
Co-authored-by: Victor Moreno <[email protected]>
Co-authored-by: Craig Disselkoen <[email protected]>
@john-h-kastner-aws @cdisselkoen
Take id as ref for EST try_into_est (#1632)
b96c20c 
Signed-off-by: John Kastner <[email protected]>
@john-h-kastner-aws @cdisselkoen
Avoid cloning self in sub_entity_literals (#1633)
2da5225 
Signed-off-by: John Kastner <[email protected]>
@dependabot @cdisselkoen
Bump the rust-dependencies group with 5 updates (#1640)
1c0d860 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @cdisselkoen
Bump the rust-dependencies group with 7 updates (#1645)
fb0463f 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@junlarsen @cdisselkoen
Parse trailing commas in Cedar policy files (#1606)
ce74a03 
Signed-off-by: Mats Jun Larsen <[email protected]>
@adpaco-aws @cdisselkoen
Optimize and inline flatten_tuple_2 (#1649)
ec0e872 
Signed-off-by: Adrian Palacios <[email protected]>
@dependabot @cdisselkoen
Bump the rust-dependencies group with 14 updates (#1653)
b15b9e9 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@mishjude @cdisselkoen
Address type mismatch false positive by implementing context validati…
d7ef3ff 
…on (#1651)

Signed-off-by: Mish Jude <[email protected]>
Co-authored-by: Mish Jude <[email protected]>
@katherine-hough @cdisselkoen
Changed coverage report action to use a directory instead of a zip to…
0b4764a 
… avoid file duplication (#1655)

Signed-off-by: Katherine Hough <[email protected]>
@katherine-hough @cdisselkoen
Free disk space in github workflow (#1657)
68e7f47 
Signed-off-by: Katherine Hough <[email protected]>
@dependabot @katherine-hough @cdisselkoen
Bump the rust-dependencies group with 27 updates (#1659)
b0f8a4a 
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Katherine Hough <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Katherine Hough <[email protected]>
@adpaco-aws @cdisselkoen
Downgrade prost and prost-build versions (#1660)
ac8a02d 
Signed-off-by: Adrian Palacios <[email protected]>
@cdisselkoen
add more impl Froms (#1670)
4491646 
Signed-off-by: Craig Disselkoen <[email protected]>
@cdisselkoen
fix bad cherrypick
170ecf3 
Signed-off-by: Craig Disselkoen <[email protected]>
@github-actions GitHub Actions
Copy link

Coverage Report

Head Commit: 170ecf38ef550f6660ee62e06fd4be6ae766d53f

Base Commit: 40be99c42cd6e102515b28db6bfb4c0b1dfc9421

Download the full coverage report.

Coverage of Added or Modified Lines of Rust Code

Required coverage: 80.00%

Actual coverage: 70.92%

Status: FAILED ❌

Details
File Status Covered Coverage Missed Lines
cedar-policy-core/src/ast/request.rs 🔴 0/8 0.00% 638-645
cedar-policy-core/src/entities/json/value.rs 🟡 6/8 75.00% 519, 543
cedar-policy-core/src/est.rs 🟢 2/2 100.00%
cedar-policy-core/src/est/expr.rs 🟢 26/27 96.30% 723
cedar-policy-core/src/parser/util.rs 🟢 11/11 100.00%
cedar-policy-validator/src/coreschema.rs 🔴 24/35 68.57% 259-261, 329-336
cedar-policy-validator/src/typecheck.rs 🟢 2/2 100.00%
cedar-policy/src/api.rs 🔴 32/59 54.24% 106-108, 377-379, 1799-1801, 2260-2262, 2996-2998, 3345-3347, 3352-3354, 3875-3877, 4303-4305
cedar-policy/src/ffi/check_parse.rs 🟢 10/11 90.91% 167
cedar-policy/src/ffi/convert.rs 🔴 15/22 68.18% 51-56, 205
cedar-policy/src/ffi/utils.rs 🟢 11/11 100.00%

Coverage of All Lines of Rust Code

Required coverage: 80.00%

Actual coverage: 81.67%

Status: PASSED ✅

Details
Package Status Covered Coverage Base Coverage
cedar-policy 🔴 3214/4665 68.90% --
cedar-policy-cli 🔴 571/972 58.74% --
cedar-policy-core 🟢 11987/14230 84.24% --
cedar-policy-formatter 🟢 914/1043 87.63% --
cedar-policy-validator 🟢 8844/10321 85.69% --
cedar-wasm 🔴 0/29 0.00% --

@cdisselkoen cdisselkoen merged commit 90ca2fc into release/4.5.x Jun 26, 2025
10 of 20 checks passed
@cdisselkoen cdisselkoen deleted the cdisselkoen/4.5.x-cherrypicks branch June 26, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-h-kastner-aws john-h-kastner-aws john-h-kastner-aws approved these changes

@chaluli chaluli chaluli approved these changes

@adpaco-aws adpaco-aws Awaiting requested review from adpaco-aws

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@cdisselkoen @john-h-kastner-aws @chaluli @shaobo-he-aws @katherine-hough @Swolebrain @junlarsen @adpaco-aws @mishjude