Skip to content

Conversation

john-h-kastner-aws
Copy link
Contributor

@john-h-kastner-aws john-h-kastner-aws commented May 21, 2025

Description of changes

Get rid of a silly clone

Issue #, if available

Checklist for requesting a review

The change in this PR is (choose one, and delete the other options):

  • A breaking change requiring a major version bump to cedar-policy (e.g., changes to the signature of an existing API).
  • A backwards-compatible change requiring a minor version bump to cedar-policy (e.g., addition of a new API).
  • A bug fix or other functionality change requiring a patch to cedar-policy.
  • A change "invisible" to users (e.g., documentation, changes to "internal" crates like cedar-policy-core, cedar-validator, etc.)
  • A change (breaking or otherwise) that only impacts unreleased or experimental code.

I confirm that this PR (choose one, and delete the other options):

  • Updates the "Unreleased" section of the CHANGELOG with a description of my change (required for major/minor version bumps).
  • Does not update the CHANGELOG because my change does not significantly impact released code.

I confirm that cedar-spec (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar formal model or DRT infrastructure.
  • Requires updates, and I have made / will make these updates myself. (Please include in your description a timeline or link to the relevant PR in cedar-spec, and how you have tested that your updates are correct.)
  • Requires updates, but I do not plan to make them in the near future. (Make sure that your changes are hidden behind a feature flag to mark them as experimental.)
  • I'm not sure how my change impacts cedar-spec. (Post your PR anyways, and we'll discuss in the comments.)

I confirm that docs.cedarpolicy.com (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar language specification.
  • Requires updates, and I have made / will make these updates myself. (Please include in your description a timeline or link to the relevant PR in cedar-docs. PRs should be targeted at a staging-X.Y branch, not main.)
  • I'm not sure how my change impacts the documentation. (Post your PR anyways, and we'll discuss in the comments.)

Copy link
Contributor

@cdisselkoen cdisselkoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Signed-off-by: John Kastner <[email protected]>
Copy link

Coverage Report

Head Commit: dc46af3fd6da8104dcf029d4237c81cfee757cd4

Base Commit: 34cbd183ce4afca579b43707bcac9037827e6760

Download the full coverage report.

Coverage of Added or Modified Lines of Rust Code

Required coverage: 80.00%

Actual coverage: 72.73%

Status: FAILED ❌

Details
File Status Covered Coverage Missed Lines
cedar-policy-core/src/entities/json/value.rs 🟡 6/8 75.00% 519, 543
cedar-policy-core/src/est/expr.rs 🔴 2/3 66.67% 723

Coverage of All Lines of Rust Code

Required coverage: 80.00%

Actual coverage: 81.89%

Status: PASSED ✅

Details
Package Status Covered Coverage Base Coverage
cedar-policy 🔴 3192/4615 69.17% --
cedar-policy-cli 🔴 571/972 58.74% --
cedar-policy-core 🟢 12055/14284 84.40% --
cedar-policy-formatter 🟢 1034/1166 88.68% --
cedar-policy-validator 🟢 8868/10343 85.74% --
cedar-wasm 🔴 0/29 0.00% --

Copy link

Coverage Report

Head Commit: b95d5ebec2d8f7283a68be044c4557fd84ef2e3b

Base Commit: 34cbd183ce4afca579b43707bcac9037827e6760

Download the full coverage report.

Coverage of Added or Modified Lines of Rust Code

Required coverage: 80.00%

Actual coverage: 72.73%

Status: FAILED ❌

Details
File Status Covered Coverage Missed Lines
cedar-policy-core/src/entities/json/value.rs 🟡 6/8 75.00% 519, 543
cedar-policy-core/src/est/expr.rs 🔴 2/3 66.67% 723

Coverage of All Lines of Rust Code

Required coverage: 80.00%

Actual coverage: 81.89%

Status: PASSED ✅

Details
Package Status Covered Coverage Base Coverage
cedar-policy 🔴 3192/4615 69.17% --
cedar-policy-cli 🔴 571/972 58.74% --
cedar-policy-core 🟢 12055/14284 84.40% --
cedar-policy-formatter 🟢 1034/1166 88.68% --
cedar-policy-validator 🟢 8868/10343 85.74% --
cedar-wasm 🔴 0/29 0.00% --

@john-h-kastner-aws john-h-kastner-aws merged commit 469dc9e into main May 21, 2025
19 of 20 checks passed
@john-h-kastner-aws john-h-kastner-aws deleted the sub_entity_literals_clone branch May 21, 2025 17:04
mishjude pushed a commit to mishjude/cedar that referenced this pull request Jun 17, 2025
Signed-off-by: John Kastner <[email protected]>
Signed-off-by: Mish Jude <[email protected]>
cdisselkoen pushed a commit that referenced this pull request Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants