fix accepting tags as an attr name
#1209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Disselkoen <[email protected]>
john-h-kastner-aws
approved these changes
Sep 17, 2024
| #[test] | ||
| fn attr_named_tags() { | ||
| let src = r#" | ||
| entity E { tags: Set<{key: String, value: Set<String>}> }; |
There was a problem hiding this comment.
IIRC, shaobo built in a warning mechanism for the Cedar schema format. Feels like it could be worth warning here.
shaobo-he-aws
approved these changes
Sep 17, 2024
shaobo-he-aws
pushed a commit
that referenced
this pull request
Sep 25, 2024
Signed-off-by: Craig Disselkoen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Bugfix for unreleased code, specifically #1204. 1204 accidentally disallowed
tagsas an attribute name, which would be a breaking change. This PR fixes that, and adds appropriate tests. Also moves around a couple test utilities so that they can be used by the new test.Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):