Skip to content

Conversation

cdisselkoen
Copy link
Contributor

Description of changes

This PR contains the schema parsing changes (both JSON and Cedar formats) for RFC 82 entity tags. It does not contain the validator changes that would allow you to actually validate getTag and hasTag operations, but it does allow you to declare tag types on entities.

Issue #, if available

Checklist for requesting a review

The change in this PR is (choose one, and delete the other options):

  • A change "invisible" to users (e.g., documentation, changes to "internal" crates like cedar-policy-core, cedar-validator, etc.)

I confirm that this PR (choose one, and delete the other options):

  • Does not update the CHANGELOG because my change does not significantly impact released code.

I confirm that cedar-spec (choose one, and delete the other options):

  • Requires updates, and I have made / will make these updates myself. (Please include in your description a timeline or link to the relevant PR in cedar-spec, and how you have tested that your updates are correct.)

@cdisselkoen cdisselkoen merged commit f199266 into main Sep 16, 2024
17 of 19 checks passed
@cdisselkoen cdisselkoen deleted the cdisselkoen/rfc-82-schema-parsing branch September 16, 2024 15:43
shaobo-he-aws pushed a commit that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants