Skip to content

Conversation

aaronjeline
Copy link

Description of changes

We decided to include #1180 in 4.0, so this updates the changelog

Issue #, if available

N/A

Checklist for requesting a review

The change in this PR is (choose one, and delete the other options):

  • A change "invisible" to users (e.g., documentation, changes to "internal" crates like cedar-policy-core, cedar-validator, etc.)

Signed-off-by: Aaron Eline <[email protected]>
Signed-off-by: Aaron Eline <[email protected]>
Copy link
Contributor

@khieta khieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed that #1177 didn't add a "fixed" entry to the changelog. Can you add that in this PR?

Adds fixed note for #1177

Co-authored-by: Kesha Hietala <[email protected]>
Signed-off-by: Aaron Eline <[email protected]>
@aaronjeline aaronjeline force-pushed the aeline/updating-changelog branch from 929e0cb to 0449b46 Compare September 10, 2024 20:08
@aaronjeline aaronjeline requested a review from khieta September 10, 2024 20:14
Copy link
Contributor

@khieta khieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more picky comment 😄

Signed-off-by: Aaron Eline <[email protected]>

Co-authored-by: Kesha Hietala <[email protected]>
@aaronjeline aaronjeline requested a review from khieta September 11, 2024 13:13
@aaronjeline aaronjeline merged commit 2256bc3 into main Sep 11, 2024
19 checks passed
@aaronjeline aaronjeline deleted the aeline/updating-changelog branch September 11, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants