Skip to content

Conversation

andrewmwells-amazon
Copy link
Contributor

@andrewmwells-amazon andrewmwells-amazon commented Sep 5, 2024

Description of changes

When constructing the SchemaType of a concrete entity, make attributes required.

Issue #, if available

#1176

Checklist for requesting a review

The change in this PR is (choose one, and delete the other options):

  • A bug fix or other functionality change requiring a patch to cedar-policy.

I confirm that this PR (choose one, and delete the other options):

  • Updates the "Unreleased" section of the CHANGELOG with a description of my change (required for major/minor version bumps).

I confirm that cedar-spec (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar formal model or DRT infrastructure.

Signed-off-by: Andrew Wells <[email protected]>
…implement_schematype function

Signed-off-by: Andrew Wells <[email protected]>
Copy link
Contributor

@cdisselkoen cdisselkoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Signed-off-by: Andrew Wells <[email protected]>
Signed-off-by: Andrew Wells <[email protected]>
@andrewmwells-amazon
Copy link
Contributor Author

Also fixes #440

Signed-off-by: Andrew Wells <[email protected]>
Signed-off-by: Andrew Wells <[email protected]>
Signed-off-by: Andrew Wells <[email protected]>
Copy link
Contributor

@john-h-kastner-aws john-h-kastner-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clippy is unhappy, but looks good otherwise

Signed-off-by: Andrew Wells <[email protected]>
Signed-off-by: Andrew Wells <[email protected]>
@andrewmwells-amazon andrewmwells-amazon merged commit 91693c2 into main Sep 10, 2024
17 of 19 checks passed
@andrewmwells-amazon andrewmwells-amazon deleted the andrewmwells/fix_1176 branch September 10, 2024 18:13
aaronjeline pushed a commit that referenced this pull request Sep 10, 2024
Signed-off-by: Andrew Wells <[email protected]>
@aaronjeline aaronjeline mentioned this pull request Sep 10, 2024
3 tasks
@khieta khieta mentioned this pull request Sep 10, 2024
1 task
aaronjeline pushed a commit that referenced this pull request Sep 10, 2024
Adds fixed note for #1177

Co-authored-by: Kesha Hietala <[email protected]>
Signed-off-by: Aaron Eline <[email protected]>
andrewmwells-amazon added a commit that referenced this pull request Sep 10, 2024
Signed-off-by: Andrew Wells <[email protected]>
andrewmwells-amazon added a commit that referenced this pull request Sep 10, 2024
Signed-off-by: Andrew Wells <[email protected]>
khieta pushed a commit that referenced this pull request Sep 10, 2024
Signed-off-by: Andrew Wells <[email protected]>
andrewmwells-amazon added a commit that referenced this pull request Sep 11, 2024
Signed-off-by: Andrew Wells <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entity validation behaves incorrectly on record-typed attributes
4 participants