Skip to content

frontend: ParameterLoader: Fix invalid parameter loaded from file #2734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2024
Merged

frontend: ParameterLoader: Fix invalid parameter loaded from file #2734

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions core/frontend/src/components/parameter-editor/ParameterLoader.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,27 +51,31 @@
<v-col class="virtual-table-cell name-cell">
<v-tooltip bottom>
<template #activator="{ on }">
<div v-on="on">
<div :style="!item.current ? { color: 'var(--v-warning-base)' } : {}" v-on="on">
{{ item.name }}
</div>
</template>
<span>
{{ item.current?.description ?? 'No description provided' }}
{{
item.current
? item.current?.description ?? 'No description provided'
: 'Parameter not found in Autopilot data, most likely will not be written to the vehicle.'
}}
</span>
</v-tooltip>
</v-col>
<v-col class="virtual-table-cell">
<v-tooltip bottom>
<v-tooltip :disabled="!item.current" bottom>
<template #activator="{ on }">
<div
class="large-text-cell"
v-on="on"
>
{{ printParamWithUnit(item.current) }}
{{ item.current ? printParamWithUnit(item.current) : 'N/A' }}
</div>
</template>
<span>
{{ printParamWithUnit(item.current) }}
{{ item.current ? printParamWithUnit(item.current) : 'N/A' }}
</span>
</v-tooltip>
</v-col>
Expand All @@ -82,11 +86,11 @@
class="large-text-cell"
v-on="on"
>
{{ printParamWithUnit(item.new) }}
{{ item.current ? printParamWithUnit(item.new) : item.new.value }}
</div>
</template>
<span>
{{ printParamWithUnit(item.new) }}
{{ item.current ? printParamWithUnit(item.new) : item.new.value }}
</span>
</v-tooltip>
</v-col>
Expand Down Expand Up @@ -294,7 +298,7 @@ export default Vue.extend({

return {
name,
current: currentParameter,
current: currentParameter ?? undefined,
new: { ...currentParameter, value },
}
})
Expand Down