frontend: ParameterLoader: Fix invalid parameter loaded from file #2734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaomariolago
force-pushed
the
fix-invalid-parameter-load-from-file
branch
2 times, most recently
from
df97ee5 to
3c5fc64
Compare
* Change to not use printParamWithUnit when parameter is not found in autopilot_data, instead uses N/A for current and just raw value for new parameter
joaomariolago
force-pushed
the
fix-invalid-parameter-load-from-file
branch
from
3c5fc64 to
d074fb6
Compare
joaomariolago
requested review from
patrickelectric,
Williangalvani and
joaoantoniocardoso
patrickelectric
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2704
Add validation in case of loading a parameter that is not present on autopilot_data
