client: Relax IncorrectSecret condition #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bilelmoussaoui
force-pushed
the
bilelmoussaoui/file-backend-fixes
branch
from
266860a to
e48a46e
Compare
zecakeh
reviewed
Mar 20, 2025
Contributor
zecakeh
left a comment
zecakeh
left a comment
There was a problem hiding this comment.
The API looks good, I'm going to try to use it in Fractal.
zecakeh
reviewed
Mar 20, 2025
zecakeh
reviewed
Mar 20, 2025
bilelmoussaoui
force-pushed
the
bilelmoussaoui/file-backend-fixes
branch
3 times, most recently
from
c2a077a to
ba0f30f
Compare
zecakeh
reviewed
Mar 20, 2025
See <#207> for context.
Useful for the previous commit.
Make it use the fixture keyring instead of a random one
bilelmoussaoui
force-pushed
the
bilelmoussaoui/file-backend-fixes
branch
from
ba0f30f to
cf11ca8
Compare
bilelmoussaoui
commented
Mar 20, 2025
Make it easy to do the migration code path without forcing every API to write a bunch of code
bilelmoussaoui
force-pushed
the
bilelmoussaoui/file-backend-fixes
branch
from
cf11ca8 to
2ec6eb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #207
cc @zecakeh