After upgrading to 0.4.0, some users get a `file::Error::IncorrectSecret` error

[zecakeh]

For some users the upgrade is fine, but for others, they get this error which seems to mean that oo7 fails to decrypt the items in the file? See fractal#1603.

Downgrading back to 0.3.x works so its looks like it's a regression.

[bilelmoussaoui]

This seems to be caused by 3ba3e8d which is unexpected?

[zecakeh]

We could add a log for the error at

oo7/client/src/file/mod.rs

Line 123 in a4421d1

if encrypted_item.clone().decrypt(&key).is_err() {

to know what the actual error is.

[bilelmoussaoui]

That indeed would give us more insights

[bilelmoussaoui]

@zecakeh I published a 0.4.1 with the added log. Please re-switch back to 0.4 in Fractal and see what causes the issue. Thanks!

[zecakeh]

This is the log that we get:

ERROR oo7::file: Failed to decrypt item, incorrect secret?: Mac digest is not equal to the expected value

[bilelmoussaoui]

@zecakeh does this happen when using the secret portal or when interacting with the host keyring ?

[zecakeh]

With the secret portal

[bilelmoussaoui]

Interesting. I guess the next debugging step we can do here is to see how many items have this issue (if there are more than one).

[zecakeh]

So we added more logs to look into it. The user we tested with expected to have 2 sessions. There are 3 encrypted items, only one of them failing to decrypt. The 2 that succeed to decrypt are the expected sessions.

Looking at the map of hashed attributes in the encrypted item, it looks like a very old item, that could even possibly have been created by libsecret before we were using oo7. So we have no idea why it's still here.

[bilelmoussaoui]

Hmmm, so basically what happened is prior to 0.4 we would allow you to write new items even when the secret is incorrect which would have lead to this issue in the past.

I am not sure what would be the best way forward here without potentially removing secrets that the user can care about without their consent

[zecakeh]

Maybe not error, but return a list/count of items that failed to decrypt?

[zecakeh]

Except if all items failed to decrypt maybe