Skip to content

Update to Support Node 10 & 11 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 9, 2019
Merged

Update to Support Node 10 & 11 #6

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1745bd2
chore: updated appveyor with node 10,12 and removed <6
Sep 5, 2019
2236078
chore: added intermidiate versions to travis and appveyor
Sep 5, 2019
d7cf183
chore: removed node 12 as it doesn't compile
Sep 6, 2019
8f5e1e4
chore: bumped version of package and gcc
Sep 6, 2019
51d3152
refactor: changed callback bridge local context
Sep 6, 2019
4835776
chore: updated node engines
Sep 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,12 @@ env:
global:
- SKIP_SASS_BINARY_DOWNLOAD_FOR_CI=true
matrix:
- export NODE_VERSION="11"
- export NODE_VERSION="10"
- export NODE_VERSION="9"
- export NODE_VERSION="8"
- export NODE_VERSION="7"
- export NODE_VERSION="6"
- export NODE_VERSION="5"
- export NODE_VERSION="4"

matrix:
fast_finish: true
Expand All @@ -24,8 +25,8 @@ addons:
sources:
- ubuntu-toolchain-r-test
packages:
- gcc-4.7
- g++-4.7
- gcc-4.9
- g++-4.9

before_install:
- git submodule update --init --recursive
Expand All @@ -36,10 +37,10 @@ before_install:
- nvm use $NODE_VERSION
- npm config set python `which python`
- if [ $TRAVIS_OS_NAME == "linux" ]; then
export CC="gcc-4.7";
export CXX="g++-4.7";
export LINK="gcc-4.7";
export LINKXX="g++-4.7";
export CC="gcc-4.9";
export CXX="g++-4.9";
export LINK="gcc-4.9";
export LINKXX="g++-4.9";
fi
- nvm --version
- node --version
Expand Down
5 changes: 3 additions & 2 deletions appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,12 @@
environment:
SKIP_SASS_BINARY_DOWNLOAD_FOR_CI: true
matrix:
- nodejs_version: 11
- nodejs_version: 10
- nodejs_version: 9
- nodejs_version: 8
- nodejs_version: 7
- nodejs_version: 6
- nodejs_version: 5
- nodejs_version: 4

install:
- ps: Install-Product node $env:nodejs_version $env:platform
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@bigcommerce/node-sass",
"version": "3.4.4",
"version": "3.4.5",
"libsass": "3.3.2",
"description": "Wrapper around libsass",
"license": "MIT",
Expand Down
2 changes: 1 addition & 1 deletion src/callback_bridge.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ T CallbackBridge<T, L>::operator()(std::vector<void*> argv) {
argv_v8.push_back(Nan::New(wrapper));

return this->post_process_return_value(
this->callback->Call(argv_v8.size(), &argv_v8[0])
Nan::Call(*this->callback, argv_v8.size(), &argv_v8[0]).ToLocalChecked()
);
} else {
/*
Expand Down