Skip to content

Conversation

ncheikh
Copy link

@ncheikh ncheikh commented Sep 5, 2019

Updating to build for node 10 & 11

Removed build for Node < 6

Tested locally with a sampling of themes, stencil-cli, stencil-styles

@ncheikh ncheikh changed the title Update to Support Node 10 & 12 Update to Support Node 10 & 11 Sep 6, 2019
Copy link

@junedkazi junedkazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also update the node engine to be greater or equal to 6 and less than 12 for now.

@junedkazi junedkazi mentioned this pull request Sep 6, 2019
@ncheikh
Copy link
Author

ncheikh commented Sep 6, 2019

@junedkazi change was made and ready for review

@franzese
Copy link

franzese commented Sep 6, 2019

Very hopeful about this PR! 👍

@ncheikh ncheikh merged commit 8c6962e into bigcommerce-labs:master Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants