Skip to content

Conversation

@forman
Copy link
Member

@forman forman commented Mar 18, 2024

Closes #82

Also reworked section Slice Sources in documentation.

Checklist (strike out non-applicable):

  • Changes documented in CHANGES.md
  • Related issue exists and is referred to in the PR description and CHANGES.md
  • Added docstrings and API docs for any new/modified user-facing classes and functions
  • Changes/features documented in docs/*
  • Unit-tests adapted/added for changes/features
  • Test coverage remains or increases (target 100%)

@forman forman self-assigned this Mar 18, 2024
@codecov
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.93%. Comparing base (db3ab06) to head (2a23449).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #86   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files          30       30           
  Lines        1443     1446    +3     
=======================================
+ Hits         1442     1445    +3     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@forman forman added the enhancement New feature or request label Mar 18, 2024
@forman forman added the documentation Improvements or additions to documentation label Mar 19, 2024
@forman forman marked this pull request as ready for review March 19, 2024 11:22
@forman forman requested a review from pont-us March 19, 2024 14:30
Co-authored-by: Pontus Lurcock <[email protected]>
@forman forman merged commit 4a6338a into main Mar 19, 2024
@forman forman deleted the forman-82-config_setting_extra branch March 19, 2024 16:17
@forman
Copy link
Member Author

forman commented Mar 19, 2024

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Further ease writing custom slice sources

3 participants