Skip to content

Conversation

@forman
Copy link
Member

@forman forman commented Mar 15, 2024

  • Slice items can now be a contextlib.AbstractContextManager so custom slice functions can now be used with @contextlib.contextmanager.
  • Deprecated SliceSource.dispose() and introduced SliceSource.close().

To close #82, also see #84 and #86.

Checklist (strike out non-applicable):

  • Changes documented in CHANGES.md
  • Related issue exists and is referred to in the PR description and CHANGES.md
  • Added docstrings and API docs for any new/modified user-facing classes and functions
  • Changes/features documented in docs/*
  • Unit-tests adapted/added for changes/features
  • Test coverage remains or increases (target 100%)

…d SliceSource.dispose() and introduced SliceSource.close().
@codecov
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.93%. Comparing base (70e739c) to head (c9228ae).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #83   +/-   ##
=======================================
  Coverage   99.92%   99.93%           
=======================================
  Files          30       30           
  Lines        1428     1436    +8     
=======================================
+ Hits         1427     1435    +8     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@forman forman self-assigned this Mar 15, 2024
@forman forman added the enhancement New feature or request label Mar 15, 2024
@forman forman marked this pull request as ready for review March 18, 2024 10:59
@forman forman merged commit 8dc8167 into main Mar 19, 2024
@forman forman deleted the forman-82-slice_source_is_cm branch March 19, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Further ease writing custom slice sources

3 participants