Skip to content

Test Laravel 12 #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 24, 2025
Merged

Test Laravel 12 #538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c24a0cf
Test Laravel 12
barryvdh Feb 21, 2025
5346889
Update composer.json
barryvdh Feb 21, 2025
f3dd1a5
Update run-tests.yml
barryvdh Feb 21, 2025
e644c7c
Update run-tests.yml
barryvdh Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/workflows/run-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,7 @@ on:
- master
pull_request:
branches:
- *
schedule:
- cron: '0 0 * * *'
- "*"

jobs:
php-tests:
Expand All @@ -21,16 +19,18 @@ jobs:

strategy:
matrix:
php: [8.2, 8.1, 8.0]
php: [8.4, 8.3, 8.2, 8.1]
laravel: ['9.*', '10.*', '11.*']
dependency-version: [prefer-lowest, prefer-stable]
exclude:
- laravel: 9.*
php: 8.4
- laravel: 10.*
php: 8.0
php: 8.4
- laravel: 11.*
php: 8.1
- laravel: 11.*
php: 8.0
- laravel: 12.*
php: 8.1

name: P${{ matrix.php }} - L${{ matrix.laravel }} - ${{ matrix.dependency-version }}

Expand All @@ -45,7 +45,7 @@ jobs:
sudo dpkg -i wkhtmltox_0.12.6-1.bionic_amd64.deb

- name: Setup PHP
uses: shivammathur/setup-php@v4
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php }}
coverage: none
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
}
],
"require": {
"php": ">=7.2",
"php": "^8.1",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumping php version in a patch release is questionable. Should there be a security issue in 1.0.3, what version number would you use for a fix?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHP8.0 and below are not supported anymore by PHP, so I suggest that people who are still on 7.2-8.0 upgrade as soon as possible.
I also think it's a vary small change that a security fix will be required, as wkhtmltopdf is also EOL and this library is just a wrapper for Snappy which also only supports 8.1 and above, see https://github.com/KnpLabs/snappy/blob/master/composer.json

But otherwise I guess I could release 1.0.3.1 if required?

"illuminate/support": "^9|^10|^11|^12",
"illuminate/filesystem": "^9|^10|^11|^12",
"knplabs/knp-snappy": "^1.4.4"
Expand Down
Loading